[
https://issues.apache.org/jira/browse/OFBIZ-1393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543277
]
Bilgin Ibryam commented on OFBIZ-1393:
--------------------------------------
Hi Cris,
This is an improvement (should go only to trunk) and i think testing on trunk
should be enough.
The patch is fine and working as expected. There is only an extra space in the
patch.
But i have two design question:
1. Why you decided to add this new field to ProductConfig entity but not to
ProductConfigOption as Jacopo sugested ? May be there is a reason that i cannot
see ? For me, at first look, this new field belongs to ProductConfigOption or
ProductConfigItem.
2. The name of the field you added "defaultConfigItemId" confused me, I thought
that it is pointing to a configItemId, but actually this field points to a
configOptionId. May be the name (ok, it should be less than 20) should be
something like defaultConfOptionId, telling that this is an default option Id.
Just my 2 cents.
Regards,
Bilgin Ibryam
> Need a better way to specify the default item configuration
> -----------------------------------------------------------
>
> Key: OFBIZ-1393
> URL: https://issues.apache.org/jira/browse/OFBIZ-1393
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk, Release Branch 4.0
> Reporter: Chris Lombardi
> Priority: Minor
> Attachments: ofbiz-1393.patch
>
>
> Currently, setDefaultConfig in ProductConfigWrapper assumes the default is
> the first ProductConfigOption. I would like to be able to set up different
> products that shared a set of ProductConfigOptions yet allow for a different
> default ProductConfigOption.
> I don't yet have an opinion on how I can best implement this and my Data
> Model Resource Book is in the mail. Does anyone have any thoughts or
> preferences?
> Here's how it's currently implemented:
> public void setDefaultConfig() {
> resetConfig();
> for (int i = 0; i < questions.size(); i++) {
> ConfigItem ci = (ConfigItem)questions.get(i);
> if (ci.isMandatory()) {
> if (ci.getOptions().size() > 0) {
> ConfigOption co = (ConfigOption)ci.getOptions().get(0);
> // default is first option
> co.setSelected(true);
> }
> }
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
