Re: svn commit: r1807045 - /ofbiz/ofbiz-framework/trunk/framework/common/src/main/java/org/apache/ofbi z/common/CommonEvents.java

[Jacques Le Roux]

I think Wai asked for that because he needs it for a custom project. It's sill 
reasonably encapsulated.

You can revert if you want

Jacques


Le 02/09/2017 à 20:06, Taher Alkhateeb a écrit :

Do we have any derived classes that require exposing these interfaces?

I think it's not a good design to break encapsulation just because of
things we "might" need.

On Sat, Sep 2, 2017 at 3:25 PM,  <jler...@apache.org> wrote:

Author: jleroux
Date: Sat Sep  2 12:25:13 2017
New Revision: 1807045

URL: http://svn.apache.org/viewvc?rev=1807045&view=rev
Log:
Improved: CommonEvents improvements
(OFBIZ-9673)

Replaces private to protected so that CommonEvents.java is more usable to
derived classes.

Thanks: Wai

Modified:
     
ofbiz/ofbiz-framework/trunk/framework/common/src/main/java/org/apache/ofbiz/common/CommonEvents.java

Modified: 
ofbiz/ofbiz-framework/trunk/framework/common/src/main/java/org/apache/ofbiz/common/CommonEvents.java
URL: 
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/src/main/java/org/apache/ofbiz/common/CommonEvents.java?rev=1807045&r1=1807044&r2=1807045&view=diff
==============================================================================
--- 
ofbiz/ofbiz-framework/trunk/framework/common/src/main/java/org/apache/ofbiz/common/CommonEvents.java
 (original)
+++ 
ofbiz/ofbiz-framework/trunk/framework/common/src/main/java/org/apache/ofbiz/common/CommonEvents.java
 Sat Sep  2 12:25:13 2017
@@ -68,7 +68,7 @@ public class CommonEvents {

      public static final String module = CommonEvents.class.getName();

-    private static final String[] ignoreAttrs = new String[] { // Attributes 
removed for security reason; _ERROR_MESSAGE_ is kept
+    static final String[] ignoreAttrs = new String[] { // Attributes removed 
for security reason; _ERROR_MESSAGE_ is kept
          "javax.servlet.request.key_size",
          "_CONTEXT_ROOT_",
          "_FORWARDED_FROM_SERVLET_",
@@ -82,7 +82,7 @@ public class CommonEvents {
          "thisRequestUri"
      };

-    private static final UtilCache<String, Map<String, String>> appletSessions = 
UtilCache.createUtilCache("AppletSessions", 0, 600000, true);
+    static final UtilCache<String, Map<String, String>> appletSessions = 
UtilCache.createUtilCache("AppletSessions", 0, 600000, true);

      public static String checkAppletRequest(HttpServletRequest request, 
HttpServletResponse response) {
          Delegator delegator = (Delegator) request.getAttribute("delegator");
@@ -309,7 +309,7 @@ public class CommonEvents {
          return "success";
      }

-    private static void writeJSONtoResponse(JSON json, HttpServletRequest 
request, HttpServletResponse response) throws UnsupportedEncodingException {
+    static void writeJSONtoResponse(JSON json, HttpServletRequest request, 
HttpServletResponse response) throws UnsupportedEncodingException {
          String jsonStr = json.toString();
          if (jsonStr == null) {
              Debug.logError("JSON Object was empty; fatal error!", module);