Every code change is at a minimum an improvement. Our other tags are just more specific improvements e.g. a fix is an improvement to something that was previously broken.
Regards Scott On 9/02/2018 06:19, "Jacques Le Roux" <[email protected]> wrote: > I use completed for these cases because it's not really an improvement, > just syntax sugar, that's OK (we agreed when we created the template) > > Jacques > > > Le 08/02/2018 à 18:12, Jacques Le Roux a écrit : > >> Yes sure >> >> Jacques >> >> >> Le 08/02/2018 à 16:16, Michael Brohl a écrit : >> >>> Hi Jacques, >>> >>> can you please use "Improved:..." for these commit messages? >>> >>> The "No functional change" message permanently requires extra work to >>> sort out when we prepare the blog details. >>> >>> Thank you, >>> >>> Michael >>> >>> >>> Am 08.02.18 um 16:01 schrieb [email protected]: >>> >>>> Author: jleroux >>>> Date: Thu Feb 8 15:01:54 2018 >>>> New Revision: 1823562 >>>> >>>> URL: http://svn.apache.org/viewvc?rev=1823562&view=rev >>>> Log: >>>> No functional change, just better syntax >>>> >>>> Modified: >>>> ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/ >>>> org/apache/ofbiz/webapp/control/ExternalLoginKeysManager.java >>>> >>>> Modified: ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/ >>>> org/apache/ofbiz/webapp/control/ExternalLoginKeysManager.java >>>> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/fra >>>> mework/webapp/src/main/java/org/apache/ofbiz/webapp/contro >>>> l/ExternalLoginKeysManager.java?rev=1823562&r1=1823561& >>>> r2=1823562&view=diff >>>> ============================================================ >>>> ================== >>>> --- ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/ >>>> org/apache/ofbiz/webapp/control/ExternalLoginKeysManager.java >>>> (original) >>>> +++ ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/ >>>> org/apache/ofbiz/webapp/control/ExternalLoginKeysManager.java Thu Feb >>>> 8 15:01:54 2018 >>>> @@ -183,7 +183,7 @@ public class ExternalLoginKeysManager { >>>> HttpSession session = request.getSession(); >>>> // The target server does not allow external login by >>>> default >>>> - boolean useExternalServer = >>>> "Y".equals(EntityUtilProperties.getPropertyValue("security", >>>> "use-external-server", "N", delegator)); >>>> + boolean useExternalServer = >>>> EntityUtilProperties.getPropertyAsBoolean("security", >>>> "use-external-server", false); >>>> String sourceWebappName = request.getParameter(SOURCE_SE >>>> RVER_WEBAPP_NAME); >>>> if (!useExternalServer || sourceWebappName == null) return >>>> "success"; // Nothing to do here >>>> >>>> >>>> >>> >>> >> >> >
