Not at all, it checks that we are putting the license header in our files as 
it's requested by ASF policy

Jacques


Le 19/03/2018 à 09:44, Taher Alkhateeb a écrit :
I'm not sure why we're using RAT anymore? I thought this is mostly for
incubating projects to help them transition and license their files.
Perhaps it might be simpler to remove it from the build script to
reduce complexity?

On Mon, Mar 19, 2018 at 11:23 AM, Jacques Le Roux
<[email protected]> wrote:
Hi Michael,

RAT still reports .adoc files as missing a license header
https://ci.apache.org/projects/ofbiz/rat-output.html

I see 2 reasons:

  * RAT does not know how to handle comment in .adoc files (more likely) so
does not find the license header
  * It's not the right way to comment a license header in .adoc files (at
least from RAT POV)

Could you please create a Jira request in CREADUR to clarify?

https://issues.apache.org/jira/projects/RAT/issues/RAT-248?filter=allopenissues

Thanks

Jacques



Le 18/03/2018 à 14:36, Jacques Le Roux a écrit :
Thanks Michael,

Weirdly Buildbot did not grasp the commit

Let's wait, it's OK anyway

Jacques


Le 18/03/2018 à 14:06, Michael Brohl a écrit :
Done.

Michael

Am 18.03.18 um 13:27 schrieb Michael Brohl:
Thanks for the hint, Pierre.

I will take care of it and complete the existing .adoc files, also leave
a notice in the wiki.

Thanks,

Michael


Am 18.03.18 um 12:28 schrieb Pierre Smits:
Hi All,

Please be aware that when an .adoc artefact is committed to the repo
that
the file has the Apache header in place.

Best regards,

Pierre Smits

ORRTIZ.COM <http://www.orrtiz.com>
OFBiz based solutions & services

OEM - The OFBiz Extensions Marketplace1
http://oem.ofbizci.net/oci-2/
1 not affiliated to (and not endorsed by) the OFBiz project





Reply via email to