Re: svn commit: r1831567 - /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/META-INF/

[Michael Brohl]

Hi Nicolas, Taher,




Sorry for the noise,

Michael


Am 17.05.18 um 10:36 schrieb Taher Alkhateeb:

thanks for reporting. It still looks ugly to have this META-INF directory but I've reverted the commit.

If I remember correctly I think I put it there for this exact reason. It
used to be declared inside ant scripts and when we moved to gradle I
thought it looked ugly in the script so I moved it out as a declared
service.

On Thu, May 17, 2018, 11:34 AM Nicolas Malin <nicolas.ma...@nereide.fr>
wrote:

Hello Michael,

This commit break base tests :

~/workspace/apache-svn/ofbiz-trunk-test

poveglia$ svn up -r1831566

poveglia$ ./gradlew  "ofbiz --test component=base --test
suitename=basetests"

[...]

BUILD SUCCESSFUL in 2m 7s

poveglia$ svn up -r1831567

Mise à jour de '.' :

D    framework/base/src/main/java/META-INF

Actualisé à la révision 1831567.

~/workspace/apache-svn/ofbiz-trunk-test

poveglia$ ./gradlew  "ofbiz --test component=base --test
suitename=basetests"B

BUILD FAILED in 57s


with in test result log :

    <testcase classname="org.apache.ofbiz.base.util.test.UtilObjectTests"
name="testGetObjectFromFactory" time="0.01">

      <error message="java.lang.Class"
type="java.lang.ClassNotFoundException">java.lang.ClassNotFoundException:
java.lang.Class

      at
org.apache.ofbiz.base.util.UtilObject.getObjectFromFactory(UtilObject.java:205)...</error>

    </testcase>

Can you have the time to check or do you want some help to fix this issue ?
Nicolas

On 14/05/2018 15:34, mbr...@apache.org wrote:

Author: mbrohl
Date: Mon May 14 13:34:03 2018
New Revision: 1831567

URL: http://svn.apache.org/viewvc?rev=1831567&view=rev
Log:
Fixed: Removed unnecessary class and folders.

Removed:
      ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/META-INF/

smime.p7s
Description: S/MIME Cryptographic Signature