Hi Mathieu,
Le 03/07/2018 à 14:53, Mathieu Lirzin a écrit :
Hello Jacques,
Jacques Le Roux <[email protected]> writes:
[snip]
private static final long serialVersionUID = -8765719278480440687L;
In OFBiz we don't set serialVersionUID but let the system handles that for us and rather
use @SuppressWarnings("serial") where necessary.
More at https://markmail.org/message/jjhf5p5hbhon7vam and above. I'll
try to write a word about that in our coding conventions or elsewhere?
I agree this should go in OFBiz coding conventions. Maybe this goes
beyond your question but it would be great if the contributing/coding
guidelines was included in the OFBiz developer manual instead of the
Wiki.
I'll put it in the "coding conventions" page for now. I agree this page should better be in developer manual, I'll consider that in future, thanks for
the idea.
Not a big deal but I saw you often (automatically?) format length lines to 80
or so
- private final String defaultStatusCodeString =
UtilProperties.getPropertyValue("requestHandler", "status-code", "302");
+ private final static String defaultStatusCodeString =
+ UtilProperties.getPropertyValue("requestHandler", "status-code",
"302");
We have commonly decided to use a length of lines 120, see
https://cwiki.apache.org/confluence/display/OFBIZ/Coding+Conventions
https://svn.apache.org/repos/asf/ofbiz/tools/wiki-files/OFBizJavaFormatter.xml
OK I will adjust my code. Maybe the line length of 120 could be
explicitly stated as an exception to the Sun standard [1]?
Yes, good idea, I'll do so
Thanks
Thanks.
[1]
http://www.oracle.com/technetwork/java/javase/documentation/codeconventions-136091.html#313
