+1 for the patch, simple and clean.
On Sat, Jul 21, 2018 at 6:58 PM, Mathieu Lirzin <[email protected]> wrote: > Taher Alkhateeb <[email protected]> writes: > >> I didn't get into it before, but my first gut reaction is .. delete >> that thing! :) > > :-) > >> Anyway, it seems to have to many references, so I would advise >> investigating how it is constructed to understand what is being pulled >> in. Just begin from the container loader and work your way down with a >> debugger until you hit exactly the reason why this check was in place. > > I have put a breakpoint inside the if branch of the overidden ‘get’ > method and started to randomly navigate OFBiz. I have found some > callers of this “feature” which can be triggered for example via the > <https://localhost:8443/facility/control/EditFacility?facilityId=WebStoreWarehouse> > URI. > > The reason is that some Freemarker template files are referencing the > ‘context’ map explicitly. I have no experience writing “.ftl” files so > I am not sure if this is a good thing or not. It seems required since > my attempts to replace those ‘context’ references by globals have > failed. > > As shown by next patch, I would like to replace the hardcoded special > case in ‘MapStack’ by explicitly adding the ‘context’ Map in the > FreeMarker model at rendering time. > > > > WDYT? > > -- > Mathieu Lirzin > GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37 >
