There's also a remark by Deepak.I'm in favor of reverting and providing a new solution once it covers all remarks. We should not leave it in the codebase in this state.
Best regards, Michael Brohl ecomify GmbH www.ecomify.de Am 30.07.18 um 10:14 schrieb Gil Portenseigne:
Hello Suraj, Regarding Nicolas feedback and mine onto Jira https://issues.apache.org/jira/browse/OFBIZ-7598, did you find time to look into it ? Thanks, Gil Le mardi 17 juil. 2018 à 14:04:06 (+0200), Nicolas Malin a écrit :Hello Suraj, On 14/07/2018 07:10, [email protected] wrote:Modified: ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelForm.java URL:http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelForm.java?rev=1835869&r1=1835868&r2=1835869&view=diff ============================================================================== --- ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelForm.java (original) +++ ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelForm.java Sat Jul 14 05:10:00 2018 @@ -147,7 +147,7 @@ public abstract class ModelForm extends private final String formWidgetAreaStyle; private final boolean groupColumns; private final String headerRowStyle; - private final boolean hideHeader; + private boolean hideHeader;With this commit you change the model during ofbiz execution and this break the thread safe. I will try to found an other to correct this Nicolas
smime.p7s
Description: S/MIME Cryptographic Signature
