[ 
https://issues.apache.org/jira/browse/OFBIZ-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548207
 ] 

Jacopo Cappellato commented on OFBIZ-1453:
------------------------------------------

Bilgin,

it's great to see implemented this part of the system.
I yet didn't have a chance to review your patch (I will do as soon as I have a 
free moment) but I think that what you did is interesting.
My only and main concern is that there could be possibly (several) other places 
where we would need the configId.
For example, what about inventory? And what about inventory reservation 
routines, picking lists, shipments, returns, work efforts (e.g. production 
runs)?
My fear is that the configId field could be required potentially everywhere we 
have a productId.
That is why I also suggested to consider the approach of creating a new product 
when a new configuration for an aggregate product is needed.
By the way, also this approach has some cons... so I still don't have a strong 
opinion on the best solution. Maybe what you have implemented is fine.
I'd love to get feedback from others.

Jacopo


> store/load possibility for AGGREGATED product configurations
> ------------------------------------------------------------
>
>                 Key: OFBIZ-1453
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1453
>             Project: OFBiz
>          Issue Type: Improvement
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: aggregated.patch, aggregated_full_for_review.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to