Hi,

While working on OFBIZ-10635 I noticed this block of code in 
LoginEvents::storeLogin

        if ("Y".equals(request.getParameter("rememberMe"))) {
            setUsername(request, response);
        }

It was added by Andrew long ago: https://markmail.org/message/dmqqxse65inh6amr

But rememberMe is never created  in code so LoginEvents::setUsername is never 
used.

I think we should remove this  block of code and the 2 related methods below.

I will do in a week w/o opinions.

--
Jacques

Reply via email to