Le 02/06/2019 à 15:50, Mathieu Lirzin a écrit :
Hello Jacques,
Jacques Le Roux <[email protected]> writes:
We started a discussion in OFBIZ-1463 about committing or not the Minilang test
patches.
There are already few mixed opinions there (Michael, Aditya, Suraj and I).
Before voting I'd like to know if we can come to a consensus.
Please read in OFBIZ-1463 and come back with your opinion.
I have just changed mine because I believe using the tests as soon they are
reading is a good thing.
Waiting would be a waste of not only work done but also time for code
safety. We can still move them to Groovy later, it's not more work, I
guess it's even less.
If it's less work, then why people interested in having those patches
applied has not migrate those tests yet? :-)
Having contributed to the migration of the “quoteTests” I know for a
fact that this is painful work. Applying those patches in their current
state would simply mean putting the burden on someone else to do the
work. So I am strongly opposed to committing thoses patches before the
tests are migrated.
As far as I am concerned, if people want stuff to be committed then they
have to do their homework first.
Wait Mathieu,
Could you explain why it would me more work to migrate from a patch than to
migrate from code already in the repo?
Maybe you mean that migrating is a burden anyway, and it's better to directly
write test in Groovy?
Then I see no problems doing that and having already Minilang tests present. We
"just have" to drop Minilang tests when Groovy ones are ready.
What I'm missing?
Thanks
--
Jacques
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
