Hello Mathieu ! Done, thanks for your review, i hope it is more clear.
Gil Le 16:23 - vendredi 27 sept., Mathieu Lirzin a écrit : > Hello Gil, > > p...@apache.org writes: > > > Author: pgil > > Date: Fri Sep 27 13:52:43 2019 > > New Revision: 1867635 > > > > URL: http://svn.apache.org/viewvc?rev=1867635&view=rev > > Log: > > Improved: Refactor UelFunctions.java to remove error management via > > Exception > > (OFBIZ-11213) > > > > This refacto was done to avoid logging stackTrace exception, when it is > > possible > > to manage it without exception. > > The "avoid logging stackTrace exception" part of your commit message > gives the impression that the motivation for this rewrite is to hide > programming errors inside Uel and not necessarily to make the > implementation more understandeable. > > Can you give more context regarding this issue of unwanted/unnecessary > logged stacktraces and explain why you choose the solution of silently > hiding the "stacktrace" instead of fixing the code inside the Uel? > > Thanks. > > -- > Mathieu Lirzin > GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
