Re: svn commit: r1835235 - in /ofbiz/ofbiz-framework/trunk: applications/product/config/freemarkerTransforms.properties framework/webapp/config/freemarkerTransforms.properties

[Nicolas Malin]

Thanks Deepak,

Jacques, I saw you worked on this big issue OFBIZ-5312 ? Do you have any 
idea on impact that I raised ?

Nicolas

On 9/30/19 2:26 PM, Deepak Dixit wrote:
Hi Nicolas,

In this commit I only removed the dependency from product component,
I think the original works done under OFBIZ-5312,
I was also not sure why ofbizUrl points to the UrlRegexpTransform class,
this is part fo SEO url work.

Kind Regards,
Deepak Dixit


On Mon, Sep 30, 2019 at 4:36 PM Nicolas Malin <nicolas.ma...@nereide.fr>
wrote:

Hello,

I have a pb with this commit or the mechanism linked to it.

For issue STORE-4361 [1], tried to improve the  'forgotPassword' email
template with use website and <@ofbizUrl> to be sure that the email link
to reset the password is related to sur websiet and component where the
ask has been done.

The problem that currently it's
org.apache.ofbiz.product.category.ftl.UrlRegexpTransform class that been
use and not org.apache.ofbiz.webapp.ftl.OfbizUrlTransform. So if I force
all ofbizUrl to this last class, my improvement work because the
UrlRegexpTransform doesn't support website url build.

I didn't understand why we have the same properties on different
freemarkerTransforms properties, that in my mid generate many
understanding error. Can we thinking how solve this situation? do we
really maintain different value for the same property ?

Any help would be welcome I I'm looking forward to close this long
forget Password task :)

Regards,

Nicolas

[1] https://issues.apache.org/jira/browse/OFBIZ-4361

On 7/6/18 1:46 PM, dee...@apache.org wrote:
Author: deepak
Date: Fri Jul  6 11:46:52 2018
New Revision: 1835235

URL: http://svn.apache.org/viewvc?rev=1835235&view=rev
Log:
Fixed: Framework webapp freemarkerTransform.properties has dependency on
proudct component
(OFBIZ-10463)

Modified:

ofbiz/ofbiz-framework/trunk/applications/product/config/freemarkerTransforms.properties
ofbiz/ofbiz-framework/trunk/framework/webapp/config/freemarkerTransforms.properties
Modified:
ofbiz/ofbiz-framework/trunk/applications/product/config/freemarkerTransforms.properties
URL:
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/config/freemarkerTransforms.properties?rev=1835235&r1=1835234&r2=1835235&view=diff
==============================================================================
---
ofbiz/ofbiz-framework/trunk/applications/product/config/freemarkerTransforms.properties
(original)
+++
ofbiz/ofbiz-framework/trunk/applications/product/config/freemarkerTransforms.properties
Fri Jul  6 11:46:52 2018
@@ -25,4 +25,5 @@

  #ofbizCatalogUrl=org.apache.ofbiz.product.category.ftl.CatalogUrlDirective
  
ofbizCatalogAltUrl=org.apache.ofbiz.product.category.ftl.CatalogAltUrlSeoTransform
  ofbizCatalogUrl=org.apache.ofbiz.product.category.ftl.CatalogUrlSeoTransform
+ofbizUrl=org.apache.ofbiz.product.category.ftl.UrlRegexpTransform


Modified:
ofbiz/ofbiz-framework/trunk/framework/webapp/config/freemarkerTransforms.properties
URL:
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webapp/config/freemarkerTransforms.properties?rev=1835235&r1=1835234&r2=1835235&view=diff
==============================================================================
---
ofbiz/ofbiz-framework/trunk/framework/webapp/config/freemarkerTransforms.properties
(original)
+++
ofbiz/ofbiz-framework/trunk/framework/webapp/config/freemarkerTransforms.properties
Fri Jul  6 11:46:52 2018
@@ -21,8 +21,7 @@

   # entries are in the form: key=transform name, property=transform
class name
-#ofbizUrl=org.apache.ofbiz.webapp.ftl.OfbizUrlTransform
-ofbizUrl=org.apache.ofbiz.product.category.ftl.UrlRegexpTransform
+ofbizUrl=org.apache.ofbiz.webapp.ftl.OfbizUrlTransform
   ofbizContentUrl=org.apache.ofbiz.webapp.ftl.OfbizContentTransform
   ofbizCurrency=org.apache.ofbiz.webapp.ftl.OfbizCurrencyTransform
   ofbizAmount=org.apache.ofbiz.webapp.ftl.OfbizAmountTransform