Le 09/11/2019 à 15:31, Mathieu Lirzin a écrit :
Hello again,
‘./gradlew check’ fails after this commit, because it introduces some
linting issues.
Task :checkstyleMain FAILED
--8<---------------cut here---------------start------------->8---
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleMain'.
Checkstyle rule violations were found. See the report at:
file:///home/mthl/src/ofbiz/build/reports/checkstyle/main.html
Checkstyle files with violations: 1039
Checkstyle violations by severity: [error:37783]
--8<---------------cut here---------------end--------------->8---
jler...@apache.org writes:
[...]
+
+ Map<String, String[]> parameterMap =request.getParameterMap();
^ missing space
+ if (parameterMap != null) {
+ List<BasicNameValuePair> params = new
ArrayList<BasicNameValuePair>();
+ request.getParameterMap().forEach((name, values) -> {
+ for(String value : values) {
^ missing space
+ params.add(new BasicNameValuePair(name, value));
+ }
+ });
+ String queryString = URLEncodedUtils.format(params,
Charset.forName("UTF-8"));
+ uri = uri + "?" + queryString;
^ trailing whitespace
+ }
+
^^^^^^^^^trailing whitespaces
Can you fix those ? :-)
Yes, sure. I'll do with the parameterMap empty, not null, check. I thought I did,
certainly "some things happened" before the commit
Jacques
