Hi Jacques,

I'm not sure what convention over configuration has to do with what
you're saying :)

Anyway, it makes sense. Most GIT editors consider the first line to be
subject, and third line onward is the body of the message. So perhaps
we can move the (OFBIZ-XXXX) to the end of the first line or maybe
make it the last line in the body or something like that.


On Sun, Nov 17, 2019 at 7:05 PM Jacques Le Roux
<jacques.le.r...@les7arts.com> wrote:
>
> Hi,
>
> While working in Eclipse with Git (ie using eGit which is not my favourite 
> tool). I found a warning telling me:
>
>     "Second line should be empty to separate commit message header from body"
>
> It was argued that it's only a convention[1], but don't we prefer "convention 
> over configuration"?
>
> I suggest to change our template according to the convention, ie separate the 
> title from the issue number or put the number on the same line (split
> sometimes) than the title
>
> [1]https://bugs.eclipse.org/bugs/show_bug.cgi?id=475845
>
> What do you think?
>
> Jacques
>

Reply via email to