Hi Suraj,

I don't see a reason why we should make this field mandatory. It's one of a few other fields in the table.

It *could* be of value to remove the contactNumber, in case this part of the number is wrong and should not be displayed as long as it is fixed. Or the telecom number ist created and will be updated with the contact number later.

The service is used in several other services, that could be a problem too.

I would not change this until there is a real problem with it being empty.

Regards,

Michael


Am 12.12.19 um 09:22 schrieb Jacques Le Roux:
Hi,

I tend to agree, I see not reason to have it optional. Now I don't know what it implies in term of related changes, notably for custom projects...

All in all I don't see a lot of positive doing so. Did you cross a specific issue Suraj?

Jacques

Le 03/12/2019 à 16:42, Rishi Solanki a écrit :
Hi Suraj,
It seems writing this service just to wrap the create and update logic in
one service. So it uses the same IN parameters and constraints as inner
services have. IMO, we can change the wrapper service behavior based on
business requirements and override it.

+1 for changing it.

Best Regards,
--
Rishi Solanki
*CTO, Mindpath Technology*
Intelligent Solutions
cell: +91-98932-87847

On Tue, Dec 3, 2019 at 8:17 PM Suraj Khurana <[email protected]>
wrote:

Hello team,

There is a service named 'createUpdatePartyTelecomNumber' in which
contactNumber field is optional on service definition.
 From DB fields perspective it seems good to have it optional, ideally I think it should not. Whether you are creating or updating any party telecom details, contactNumber should be mandatory because that's the main thing to
be created/updated.

Please share your thoughts, am I missing something?

--
Best Regards,
Suraj Khurana
Technical Consultant
*HotWax Systems*
*Enterprise open source experts*
cell: 96697-50002
http://www.hotwaxsystems.com


Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

Reply via email to