Hi Deepak, I guess this also validates my proposal to do an automated vetting of contributor's code changes before these be added to the codebase.
See https://ofbiz.markmail.org/message/gkpej7gcxwidggvl?q=vetting for more information. Met vriendelijke groet, Pierre Smits *Proud* *contributor* (but unfortunately without privileges)* of* Apache OFBiz <https://ofbiz.apache.org/>, since 2008 *Apache Trafodion <https://trafodion.apache.org>, Vice President* *Apache Directory <https://directory.apache.org>, PMC Member* Apache Incubator <https://incubator.apache.org>, committer Apache Steve <https://steve.apache.org>, committer On Sun, Feb 23, 2020 at 12:17 PM Deepak Dixit <dee...@apache.org> wrote: > Hi Dev, > > https://ci.apache.org/builders/ofbizBranch17FrameworkPlugins/builds/466 > > Build failing for release 17.12, please be very careful while backporting > changes to release branches, Please make sure you are > verifying changes after merge/backport. > > Also please check the build boat failure notification, and before > committing please run the testIntegration task on local box. > ================== > > :compileJava/home/buildslave/slave/ofbizBranch17FrameworkPlugins/build/framework/common/src/main/java/org/apache/ofbiz/common/login/LoginServices.java:452: > error: cannot find symbol > .where("userLoginId", userLoginId) > ^ > symbol: variable userLoginId > location: class LoginServices > /home/buildslave/slave/ofbizBranch17FrameworkPlugins/build/framework/common/src/main/java/org/apache/ofbiz/common/login/LoginServices.java:450: > error: cannot find symbol > EntityQuery eq = EntityQuery.use(delegator) > ^ > symbol: variable delegator > location: class LoginServices > /home/buildslave/slave/ofbizBranch17FrameworkPlugins/build/framework/common/src/main/java/org/apache/ofbiz/common/login/LoginServices.java:475: > error: cannot find symbol > GenericValue userLoginPwdHistToCreate = > delegator.makeValue("UserLoginPasswordHistory", UtilMisc.toMap("userLoginId", > userLoginId,"fromDate", nowTimestamp)); > ^ > symbol: variable delegator > location: class LoginServices > /home/buildslave/slave/ofbizBranch17FrameworkPlugins/build/framework/common/src/main/java/org/apache/ofbiz/common/login/LoginServices.java:475: > error: cannot find symbol > GenericValue userLoginPwdHistToCreate = > delegator.makeValue("UserLoginPasswordHistory", UtilMisc.toMap("userLoginId", > userLoginId,"fromDate", nowTimestamp)); > > ^ > symbol: variable userLoginId > location: class LoginServices > /home/buildslave/slave/ofbizBranch17FrameworkPlugins/build/framework/common/src/main/java/org/apache/ofbiz/common/login/LoginServices.java:476: > error: cannot find symbol > userLoginPwdHistToCreate.set("currentPassword", currentPassword); > ^ > symbol: variable currentPassword > location: class LoginServices > /home/buildslave/slave/ofbizBranch17FrameworkPlugins/build/framework/common/src/main/java/org/apache/ofbiz/common/login/LoginServices.java:945: > error: variable delegator is already defined in method > checkNewPassword(GenericValue,String,String,String,String,List<String>,boolean,Locale) > Delegator delegator = userLogin.getDelegator(); > ^ > /home/buildslave/slave/ofbizBranch17FrameworkPlugins/build/framework/common/src/main/java/org/apache/ofbiz/common/login/LoginServices.java:947: > error: variable currentPassword is already defined in method > checkNewPassword(GenericValue,String,String,String,String,List<String>,boolean,Locale) > String currentPassword = userLogin.getString("currentPassword"); > ^ > Note: Some input files use or override a deprecated API. > Note: Recompile with -Xlint:deprecation for details. > Note: Some input files use unchecked or unsafe operations. > Note: Recompile with -Xlint:unchecked for details. > 7 errors FAILED > > ====================== > > > > Thanks & Regards > -- > Deepak Dixit > ofbiz.apache.org > > > On Sat, Feb 22, 2020 at 2:38 PM <build...@apache.org> wrote: > >> The Buildbot has detected a build exception on builder >> ofbizBranch17FrameworkPlugins while building ofbiz-framework. Full details >> are available at: >> >> https://ci.apache.org/builders/ofbizBranch17FrameworkPlugins/builds/466 >> >> Buildbot URL: https://ci.apache.org/ >> >> Buildslave for this Build: asf947_ubuntu >> >> Build Reason: downstream >> Build Source Stamp: [branch release17.12] >> afae70b71a7602543b289d5c4ffce505bc09161e >> Blamelist: Jacques Le Roux <jacques.le.r...@les7arts.com> >> >> BUILD FAILED: exception shell_1 upload_2 >> >> Sincerely, >> -The Buildbot >> >> >> >>