Hi Nicolas, great, thanks for reviewing and improving the code!
Please go ahead and commit, thanks, Michael Brohl ecomify GmbH - www.ecomify.de Am 27.02.20 um 16:22 schrieb Nicolas Malin:
Michael, I have lot of improvement to share with your commit (groovy syntax, code simplification) Do you prefer keep the hand, or I commit directly ? You can find some diff on my starting work here [1] Cheers, Nicolas [1] https://github.com/nmalin/ApacheOFBiz/compare/ProductService.groovy?expand=1 On 21/02/2020 17:51, [email protected] wrote:This is an automated email from the ASF dual-hosted git repository. mbrohl pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git The following commit(s) were added to refs/heads/trunk by this push: new e0a26fc Improved: Convert ProductServices.xml mini lang to groovy (OFBIZ-10231) e0a26fc is described below commit e0a26fce43eec7c84d87c0d5055ff0a87f2af796 Author: Michael Brohl <[email protected]> AuthorDate: Fri Feb 21 16:59:37 2020 +0100 Improved: Convert ProductServices.xml mini lang to groovy (OFBIZ-10231)Thanks Dennis Balkir for reporting and Sebastian Berg for the implementation.
smime.p7s
Description: S/MIME Cryptographic Signature
