Hi Suraj, I'm currently writing a comment at OFBIZ-11304 (since this morning, with details)
With Aditya's work we have already installed a pre-push automated style check hook in trunk. So everybody using trunk HEAD will pass by it (except if using --no-verify option or removing the hook by hand). But in case of PR merge this has no effect (the related commit was a PR merge). Because the hook is only local. And Infra told me they can't install a git checkstyle pre receive hook because of GH. I'll complete all the details soon... Thanks to care :) Jacques Le 16/06/2020 à 15:40, Suraj Khurana a écrit :
Hello team, As Jacques confirms in the very next commit, this was due to a checkstyle issue introduced. I would like to request all contributors to please run './gradlew check' before creating PR's. TIA. -- Best Regards, Suraj Khurana Senior Technical Consultant On Tue, Jun 16, 2020 at 4:38 PM <build...@apache.org> wrote:The Buildbot has detected a new failure on builder ofbizTrunkFrameworkPlugins while building ofbiz-framework. Full details are available at: https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1494 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: downstream Build Source Stamp: [branch trunk] a3059c097dfd2f2ce85ba6eb90ac41f2556b1a91 Blamelist: Priya Sharma <priya.sharma.9...@gmail.com> BUILD FAILED: failed check Sincerely, -The Buildbot
