Hi Jinghai,
Actually I prefer the current version. I find it easier to maintain: eg when you add a line you simply copy the line above and don't need to worry
about the comma.
I can't remember the number of cases I forgot a comma in the Buildbot config
file :)
Jacques
Le 30/06/2020 à 11:19, Shi Jinghai a écrit :
Hi Eugen,
I agree this proposal is mild cosmetic :)
发件人: Eugen Stan<mailto:eugen.s...@netdava.com>
发送时间: 2020年6月30日 17:07
收件人: dev@ofbiz.apache.org<mailto:dev@ofbiz.apache.org>; Shi
Jinghai<mailto:huaru...@hotmail.com>
主题: Re: [PROPOSAL] Change implementation/runtimeOnly in build.gradle to comma
separated style?
Hi Shi Jinghai,
What are the benefits?
Why do all this work?
It seems to me they are only mild cosmetic improvements (arguably an
improvement).
In my apps I usually copy dependencies from maven (the copy button) and
they include the 'implementation' word, as most similar sites do.
Example:
https://search.maven.org/artifact/org.huihoo/ofbiz-smart-framework/0.9.5/jar
La 30.06.2020 06:05, Shi Jinghai a scris:
Hi there,
While typing implementation, runtimeOnly and etc. in build.gradle, I find they
can be changed to comma separated style, as the build.gradle is a groovy file,
for example:
implementation 'xerces:xercesImpl:2.11.0'
implementation 'com.google.zxing:core:3.4.0'
implementation
'com.googlecode.concurrentlinkedhashmap:concurrentlinkedhashmap-lru:1.4.2'
implementation 'com.googlecode.ez-vcard:ez-vcard:0.9.10'
implementation
'com.googlecode.owasp-java-html-sanitizer:owasp-java-html-sanitizer:1.1'
EQUALS to
implementation 'xerces:xercesImpl:2.11.0',
'com.google.zxing:core:3.4.0',
'com.googlecode.concurrentlinkedhashmap:concurrentlinkedhashmap-lru:1.4.2',
'com.googlecode.ez-vcard:ez-vcard:0.9.10',
'com.googlecode.owasp-java-html-sanitizer:owasp-java-html-sanitizer:1.1'
Just the same as
int a, b
equals to
int a
int b
What do you think?
Kind Regards,
Shi Jinghai
--
Eugen Stan
+40720 898 747 / netdava.com
