I recall having at length discussions on this topic in the mentioned ticket back then. I too was a bit concerned about having too many plugins for similar type of code like payment integration or shipping integrations. But now when I think of it again, the core idea behind plugin architecture is to be able to build any number of plugins on an existing product/framework. So I think it’s fine having any number of individual plugins for these third party integrations, in fact many of the plugins today are third party integrations. We shouldn’t be needing another repository for this.
Though I would definitely suggest that we should review each of these third party integrations and only move those which are valid implementations today. There could be certain integrations which might be deprecated or defunct now due to lack of maintenance and needs to be updated or rewritten for their latest versions. It could be a good idea to create place holder Jira issues for reimplementation for contributors to pick. Thanks. -- Mridul Pathak > On 25-Jul-2020, at 11:59 AM, Pritam Kute <pritam.k...@hotwaxsystems.com> > wrote: > > Hello Devs, > > Recently, we have pushed integration of the First Data payment gateway to > OOTB. When we were doing that, we got one question about repository > management for third-party applications. We have one ticket [1] open in > JIRA about moving third party code from framework to separate repositories > to make framework lightweight. > > Now the question is how we are going to manage the repository structure for > third party integration codes. If we talk about payment gateways, we have > around 12 different integrations available in the framework component. If > we move them to plugins as a separate plugin, it will increase the number > of plugins in the plugin repository. I am personally not in favor of that. > We should have some type of repository categorization there. One > categorization I would like to suggest is to have separate repository all > together for third party integrations and to have a Gradle task to fetch > only required third party integration inside plugins directory as like we > have done for plugins repository itself: > apache - > -- ofbiz-framework > -- ofbiz-plugins > -- *ofbiz-thrid-party* > -- ofbiz-site > -- ofbiz-tools > > I would like to invite thoughts on this so that we can proceed with the > migration of third party code out of the framework. > > [1] https://issues.apache.org/jira/browse/OFBIZ-7415 > > Kind Regards, > -- > Pritam Kute
