Hi,
Somehow, while sleeping, my brain found the issue this night :)
I have extracted the file under my local repo of ofbiz-tools. For my convenience (related to copyDtds.bat and such there), ofbiz-tools is itself under
my local repo of ofbiz-framework.
There is the ofbiz-framework/.git/hooks/pre-push file there. If I move it elsewhere it works because then nothing blocks the build. I did not thought
that could happen because it's not under ofbiz-framework itself.
Anyway, it's also a +1 for me. Maybe we could still remove the warnings and
backport the change to R18?
Jacques
Le 24/10/2021 à 14:05, Jacques Le Roux a écrit :
Of course, replacing by maxErrors = 39675, all work as expected.
Le 24/10/2021 à 13:20, Jacques Le Roux a écrit :
What I did Manually:
1. Download apache-ofbiz-18.12.01.zip, OK
2. Run a previous version of ./verify-ofbiz-release.sh
apache-ofbiz-18.12.01.zip in git-bash on Win7, OK (see my previous msg)
3. Extract files from apache-ofbiz-18.12.01.zip, OK
4. Run init-gradle-wrapper.bat, OK
5. Run "gradlew cleanAll loadAll testIntegration", ~OK (always same checkstyle
issue, four tries)
Checkstyle files with violations: 1157
Checkstyle violations by severity: [error:39675]
Maybe I did something wrong, but then I can't see what...
BTW I think we can easily remove the 2 remaining warnings:
https://markmail.org/message/thxjivgibgdos6y5
HTH
Jacques
Le 24/10/2021 à 12:45, Nicolas Malin a écrit :
+1
./gradlew cleanAll loadAll testIntegration
BUILD SUCCESSFUL in 7m 14s
./gradlew check
BUILD SUCCESSFUL in 29s
I didn't reproduce the check style error :(
Nicolas
On 24/10/2021 09:40, Jacques Le Roux wrote:
-1
$ ./verify-ofbiz-release.sh apache-ofbiz-18.12.01.zip
sha check of file: apache-ofbiz-18.12.01.zip
Using sha file: apache-ofbiz-18.12.01.zip.sha512
apache-ofbiz-18.12.01.zip: B28200E4 A9ACDDAE 293A7351 98BFD7BC
E3666502 22DC9940 913327A7 1496C458 D058C97B E1AA3F37 F40E7DF7
06CBF533 22855AE5 27476E6D AF2283B8 237D3F3E
apache-ofbiz-18.12.01.zip: B28200E4 A9ACDDAE 293A7351 98BFD7BC
E3666502 22DC9940 913327A7 1496C458 D058C97B E1AA3F37 F40E7DF7
06CBF533 22855AE5 27476E6D AF2283B8 237D3F3E
sha checksum OK
GPG verification output
gpg: Signature made Sat Oct 23 16:54:15 2021
gpg: using RSA key 7A580908847AF9E0
gpg: Good signature from "Jacopo Cappellato (CODE SIGNING KEY)
<jaco...@apache.org>"
But we have a problem with
Task :checkstyleMain FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleMain'.
Checkstyle rule violations were found. See the report at:
file:///C:/projectsASF/Git/ofbiz-framework/ofbiz-tools/apache-ofbiz-18.12.01/build/reports/checkstyle/main.html
Checkstyle files with violations: 1157
Checkstyle violations by severity: [error:39675]
With maxErrors = 38802
I thought wonder why Michael did not encounter this issue (reproduced
twice)
Jacques
Le 23/10/2021 à 17:08, Jacopo Cappellato a écrit :
This is the vote thread to publish "Apache OFBiz 18.12.01", the first
release from the release17.12 branch.
The release files can be downloaded from here:
https://dist.apache.org/repos/dist/dev/ofbiz/
and are:
* apache-ofbiz-18.12.01.zip
* KEYS: text file with keys
* apache-ofbiz-18.12.01.zip.asc: the detached signature file
* apache-ofbiz-18.12.01.zip.sha512: checksum file
Please download and test the zip file and its signatures (for
instructions
on testing the signatures see
http://www.apache.org/info/verification.html).
Vote:
[ +1] release as Apache OFBiz 18.12.01
[ -1] do not release
This vote will be open for 5 days.
For more details about this process please refer to
http://www.apache.org/foundation/voting.html
Best Regards,
Jacopo
