The problem was already fixed in trunk by allowing all types of EOL, ie using
NewlineAtEndOfFile value="lf_cr_crlf"

I just backported to 18.12

Le 02/01/2022 à 10:14, Jacques Le Roux a écrit :
Thanks for waiting, it's OK now (I crossed another Windows quirk due to BOM* 
while wanting to speed using my external editor, Scite)

* https://en.wikipedia.org/wiki/Byte_order_mark

Le 02/01/2022 à 09:49, Jacques Le Roux a écrit :
Thanks Jacopo,

-1

Because of Windows, for "CheckStyleMain Task is Failing in 18.12.04" (OFBIZ-12473), I recently put 39638 in checkstyle maxErrors. That's not enough. I guess since then new lines have been added and every new lines is a checkstyle issue on Windows. Note that fortunately we have no longer any error on Trunk. But I guess the same issue will appears when we will release our 1st 20.01. I'm not sure why yet it works before releasing and not after. I guess because of the format (LF for *nix only vs CR/LF on Win).

I'll rework that to find a definitive solution. I hope it will be easy to simply remove the EOL check, not sure yet. For now I'll simply put 50000 in maxErrors in 18.12 branch.

Sorry for that, I'll let you know when ready ASAP

Jacques


Le 02/01/2022 à 08:38, Jacopo Cappellato a écrit :
This is the vote thread to release a new bug fix release for the
release18.12 branch. This new release, "Apache OFBiz 18.12.05"
supersedes all the previous releases from the same branch.

The release files can be downloaded from here:
https://dist.apache.org/repos/dist/dev/ofbiz/

and are:
* apache-ofbiz-18.12.05.zip
* KEYS: text file with keys
* apache-ofbiz-18.12.05.zip.asc: the detached signature file
* apache-ofbiz-18.12.05.zip.sha512: checksum file

Please download and test the zip file and its signatures (for
instructions on testing the signatures see [*]).

Vote:

[ +1] release as Apache OFBiz 18.12.05
[ -1] do not release

For more details about this process please read [**].
[*]
https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz#ReleaseManagementGuideforOFBiz-Votingonarelease
[**] http://www.apache.org/foundation/voting.html

Reply via email to