Hello devs, I hope you're doing good! I write because I think I found a possible issue in minilang service *reassignInventoryReservation*.
This service is called as a SECA on createPhysicalInventoryAndVariance service and at the end it deletes inventory reservation for an order items that has quantityNotReserved .gt. 0 and then re-reserve the inventory calling the service *reserveProductInventoryByFacility, *implemented by the method *reserveProductInventory* (applications/product/minilang/product/inventory/InventoryReserveServices.xml). The *reserveProductInventoryByFacility has some parameters passed in and among them there is requireInventory parameter, that is hardcoded to N, to allow back-orders (negative ATP).* In our ecommerce context this is not recommendable and the productStores are all configured to requireInventory=Y, because we do not want back-orders, but the hard-coded requireInventory "N", overrides the store setting, making the order "available" even if stock is not present for an order item. I think that it is better to check the productStore setting of the requireInventory parameter, and pass that value to the *reserveProductInventoryByFacility,* instead of a hard-coded "N". What do you think about it? If you agree I could take care of it in a Jira Task and provide a patch. Thanks in advance, Giulio -- Giulio Speri *Mp Styl**e Srl* via Antonio Meucci, 37 41019 Limidi di Soliera (MO) T 059/684916 M 347/0965506 www.mpstyle.it
