Hi Michael,
It's OK with me, less work :)
I'll just comment out the loading of CommonSystemPropertyData.xml in common
ofbiz-component.xml file
Jacques
Le 16/09/2022 à 15:36, Michael Brohl a écrit :
Hi Jacques,
I revisited the thread and discussions. My conclusion ist still the same so I
will cite it here again:
"Essentially, I'm against deprecating file based properties and be in
favor of a general fallback solution (SystemProperty -> .properties) for
all properties *except* properties which cannot be read from the
database (system startup properties etc.)
It is extremely helpful to maintain file based properties along with
templates and a build solution to populate system specific sets of
settings (we had a discussion about it). This cannot be achieved
reasonably with pure database based properties.
And again some remark: the initial problem was simply SystemProperty
demo data overriding file based properties, which can be solved by
preventing to load them by default."
The solution is pretty simple and does not need any development except to
prevent loading the demo SystemProperty data.
Changing from seed to seed-initial does not help in this case as it will still load DEMO data as seed data and will confuse users who are not aware
of the mechanism, asking themselves why their file property configuration is not used.
I recommend to leave the demo data xml file in place as an example for SystemProperty data end remove it from any loading mechanism by commenting
out the reference in ofbiz-component.xml.
Best regards,
Michael Brohl
ecomify GmbH - www.ecomify.de
Am 30.08.22 um 11:28 schrieb Jacques Le Roux:
Le 30/08/2022 à 10:20, Jacques Le Roux a écrit :
Hi,
It's a long time now I, from time to time, have a look at this issue. At some
point I had at least 13 related links, remain open only:
https://issues.apache.org/jira/browse/OFBIZ-7112 "EntityUtilProperties"
https://issues.apache.org/jira/browse/OFBIZ-6712 "Increase the number of
EntityUtilProperties methods which really use getSystemPropertyValue()"
https://issues.apache.org/jira/browse/OFBIZ-7754 "The big problem when loading
seed."
https://issues.apache.org/jira/browse/OFBIZ-6164 "Improve configurability of
OFBiz"
And somehow related (to review when the rest is done):
https://cwiki.apache.org/confluence/display/OFBIZ/Extension+in+Multitenancy+support
https://cwiki.apache.org/confluence/display/OFBIZ/Multitenancy+support
We discussed a lot about that (notably*) but did not decide about it.
* https://markmail.org/message/md6fuoouan377c6w (look rather at bottom of the
thread where some opinionated conclusions show)
For OFBIZ-7754 I notably suggested (comment there https://s.apache.org/cyx1j):
<<Since the master DB makes only sense when using tenants, I believe we
should 1st separate properties, keep generic ones in properties files and
put others in DB.>>
But Michael is basically against that, see bottom of the thread (markmail)
above.
I don't think anybody is against changing from seed to seed-initial for CommonSystemPropertyData.xml rather than removing it as suggested by Hans
(who created it).
I mean maybe some users are relying on that now. Note that it goes in the
direction I suggested above.
Then, if nobody is against, I'll close OFBIZ-7754 (and hopefully other but 7112) and create a new Jira task to separate all properties as Hans did
for CommonSystemPropertyData
Afterward I'll get back to OFBIZ-7112
What do you think?
Note that I'll not wait forever for opinions. It will not be longer than next
week.
TIA
Jacques
Regarding Michael's then reluctance, I already suggested a maybe solution:
instead of using load-initial to load alike properties from files (those that
can be tenant specific)
we could create a load-tenant reader that would be only used if <<multitenant=Y>> or if the user prefer using DB data instead of properties in file
for all properties types (ie business and system)
Michael, what do you think about that?
Another option, somehow related, is to use Taher's suggestion and have all properties in a sole file as HTTPD does, I'm not much inclined to that.
(It's only in my memories, I can't find a reference back)
I have created
https://issues.apache.org/jira/browse/OFBIZ-12689 "Separate business properties from
system properties"
https://issues.apache.org/jira/browse/OFBIZ-12688 "Change SystemProperty entity name
to BusinessProperty" (depends upon 12689)
Jacques
