I think there is some functionality in the field of (product) content
management to automatically resize images.
Has this anyting to do with it?
Regards,
Michael Brohl
ecomify GmbH - www.ecomify.de
Am 19.04.23 um 08:17 schrieb Daniel Watford:
Thanks Jacques and Jacopo for your responses.
Jacques, like you I found the path to the functionality through
controller.xml, but was not able to find any path through the UI that a
user would take to make use of the functionality.
This leads me to believe the Jcrop (and other associated) functionality is
no longer in use and, like Jacopo said, it is acceptable to remove it from
the OFBiz sources. I'll raise a ticket separate to the other npm work to do
this.
Thanks,
Dan.
On Tue, 18 Apr 2023 at 11:00, Jacopo Cappellato <jacopo.cappell...@gmail.com>
wrote:
Hello,
For cases like this one, i.e. an external dependency from old code
that is only partially functional for a long time, I think it is
acceptable to remove it (if its presence is making it more difficult
to do some new work or refactoring).
Jacopo
On Mon, Apr 17, 2023 at 7:25 PM Jacques Le Roux
<jacques.le.r...@les7arts.com> wrote:
Hi Daniel,
It's used in ImageCrop.ftl. Itself used in <screen name="ImageCropping">
inside ImageManagementScreens.xml
There is a <request-map uri="ImageCropping"> and a <form
name="ImageCropping" inside ImageManagementForms.xml related to <request-map
uri="CropImage">, etc.
I guess it's used to resize images but it does not seems to work well
(at least a jpg file was blurred)
This was initially put in in 2010 : https://s.apache.org/ak8s6 (can be
seen in https://markmail.org/message/udi25j4wyqyrowcu)
Not sure of the current quality....
HTH
Jacques
Le 17/04/2023 à 13:43, Daniel Watford a écrit :
Hello,
As part of https://issues.apache.org/jira/browse/OFBIZ-12789 I wanted
to
understand how the javascript library jcrop was being used by OFBiz.
This
is so I can ensure any replacement library sourced from npm would
continue
to work correctly.
I have found the various screen and form definitions
(ImageManagementScreens and ImageManagementForms) in
applications/product/widget/catalog, but cannot find any path through
the
UI that would take a user to these screens.
I have found the Image Management sub-application under
https://localhost:8443/catalog/control/Imagemanagement, but this
screen
does not appear to make use of image cropping or resizing.
Please could someone guide me to the correct part of the UI where
jquery.jcrop.js is used? Or perhaps this functionality was removed at
some
point and we just have some old library files let in the OFBiz sources
that
can be cleaned up?
Thanks,
Dan.
