I‘d suggest to deprecate in trunk and therefore for the next release branch 23.x. After the release branch is created, remove from trunk/next release.
Regards, Michael > Am 09.05.2023 um 19:19 schrieb Jacques Le Roux <jacques.le.r...@les7arts.com>: > > Hi, > > Tobias Hahn has created the PR#635. It looks good to me, and I have suggested > to deprecate the replaced methods. > > Then I thought that we could maybe remove the old methods. As I said in a PR > comment: > > <<I checked the usage in Java and Groovy code of the previous methods I > talked about above. Most of them are not used at all OOTB. > getPropertyAsBoolean and getPropertyAsBigDecimal are both used twice in > Java, getPropertyAsInteger is used 21 times in Java and 6 in Groovy. > > It could be that OFBiz users are using them more. But it's really easy to > replace them by UtilProperties ones or the new EntityUtilProperties ones. > So maybe we could remove them all together OOTB. And replace those used by > calls to the new ones you introduce.>> > > What do you think, should we only deprecate and wait? Note that this will > only be done in trunk. > > Thanks > > Jacques >
