Most of them indeed, there were though some remaining from previous Codenarc
work
It's easily fixed using respectively these regexp in both repos
\Rpackage (.*)\R => package $1\R
\R\R\R => \R\R
Result:
codenarc {
setConfigFile(new File('config/codenarc/codenarc.groovy'))
setMaxPriority1Violations(0)
- setMaxPriority2Violations(448)
- setMaxPriority3Violations(4396)
+ setMaxPriority2Violations(439)
+ setMaxPriority3Violations(4216)
I push these changes
Jacques
Le 01/08/2023 à 17:17, Michael Brohl a écrit :
I think this is from the groovy refactoring. The package name was set under the
License header with a single blank line.
Best would be to correct this with a script also.
Best regards,
Michael Brohl
ecomify GmbH - www.ecomify.de
Am 01.08.23 um 16:18 schrieb Jacques Le Roux:
Hi,
With last commit,
https://ci2.apache.org/#/builders/46/builds/567/steps/4/logs/stdio, we have
less priority 2 but more priority 3:
https://nightlies.apache.org/ofbiz/trunk/groovyScripts.html
<<Caused by: : Exceeded maximum number of priority 3 violations: (p1=0; p2=439;
p3=5249)>>
Compare with main build.gradle:
// Checks OFBiz Groovy coding conventions.
codenarc {
setConfigFile(new File('config/codenarc/codenarc.groovy'))
setMaxPriority1Violations(0)
setMaxPriority2Violations(448)
setMaxPriority3Violations(4396)
}
This is not blocking and according to https://github.com/apache/ofbiz-framework/commit/5d2301637f MaxPriorities has been fixed by the ones
remaining in plugins (not only it seems)
At 1st glance, most new(?) are
"Blank line precedes package declaration in file FilterOutReceipts.groovy"
"File *.groovy has consecutive blank lines"
I'll change that and will let you know...
Jacques
