Hi Jacopo, The tag on the ofbiz-framework repository triggered a non-snapshot build of the docker container image as I had hoped for, so I'm pleased with that.
The build doesn't currently take tags on the ofbiz-plugins directory into account when pulling plugins sources, so there is no need to set tags there for the moment. Unfortunately the builds triggered by tags are not able to download plugins. This appears to be due to pullAllPluginsSource.sh assuming that a branch has been checked out, which is not the case when building from a tag. We'll need a bit more thinking on how to handle this situation. Thanks, Dan. On Fri, 16 Feb 2024 at 08:07, Jacopo Cappellato <[email protected]> wrote: > Hi Daniel, > > I have created the two tags (one for the ofbiz-framework and one for > the ofbiz-plugins). Please have a look when you can and let me know if > you want me to modify them. > As a side note, if you want, I can also create the ones missing for > the previous releases. > > Thanks, > > Jacopo > > PS: did anyone else experience the same issues that Jacques is > reporting about the hash and signature? > > On Thu, Feb 15, 2024 at 8:09 PM Daniel Watford <[email protected]> wrote: > > > > +1 > > > > Jacopo, please could you try tagging the commit you used for > > the release sources as 'release18.12.12'. That should then trigger the > > building of a non-snapshot docker container image. > > > > Building of docker container images is not an official release channel > for > > OFBiz, so no need to publicise that any such images exist. But it would > be > > good to test that images are getting built by GitHub actions in response > to > > tagging releases in case we want to highlight the availability of docker > > images in future. > > > > If this vote fails, we should be able to 'move' the release tag for the > > next release attempt, prompting the build of the next non-snapshot docker > > image. > > > > Thanks, > > > > Dan. > > > > On Tue, 13 Feb 2024 at 08:35, Jacopo Cappellato < > [email protected]> > > wrote: > > > > > This is the vote thread, third attempt, to publish "Apache OFBiz > > > 18.12.12", twelfth > > > release from the release18.12 branch. > > > > > > The release files can be downloaded from here: > > > https://dist.apache.org/repos/dist/dev/ofbiz/ > > > and are: > > > * apache-ofbiz-18.12.12.zip > > > * KEYS: text file with keys > > > * apache-ofbiz-18.12.12.zip.asc: the detached signature file > > > * apache-ofbiz-18.12.12.zip.sha512: checksum file > > > > > > Please download and test the zip file and its signatures (for > > > instructions on testing the signatures see > > > http://www.apache.org/info/verification.html). > > > > > > Vote: > > > [ +1] release as Apache OFBiz 18.12.12 > > > [ -1] do not release > > > > > > This vote is open for at least 5 days. > > > > > > For more details about this process please refer to > > > http://www.apache.org/foundation/voting.html > > > > > > > > > -- > > Daniel Watford > -- Daniel Watford
