Will do, but nothing important there, just conventions...
It's like for # in 
ofbiz/trunk/applications/accounting/config/payment.properties : it changes 
nothing...

Jacques

----- Message d'origine ----- 
De : "BJ Freeman" <[EMAIL PROTECTED]>
À : <[email protected]>
Envoyé : mardi 18 décembre 2007 22:19
Objet : Re: svn commit: r605326 - 
/ofbiz/trunk/applications/accounting/webapp/accounting/payment/manualTx.ftl


> +1
>
> Jacopo Cappellato sent the following on 12/18/2007 1:16 PM:
> > Ah, now understand...
> > Well, we definitely can replace:
> >
> > +<#-- the select one option is so the list will fire on any seletion -->
> > +  <option value="Select one">${uiLabelMap.CommonSelectOne}</option>
> >
> > with:
> >
> > +  <option value="">${uiLabelMap.CommonSelectOne}</option>
> >
> > andd get the same effect.
> >
> > Jacopo
> >
> >
> > Jacopo Cappellato wrote:
> >> Jacques,
> >>
> >> is there a way to implement this in a cleaner way?
> >> I really don't know anything about this screen, but if we really need
> >> to provide a non null string (but are we sure that it is not just a
> >> configuration issue?) maybe we should adopt a more standard name: for
> >> example "_NA_" instead of "Select one".
> >>
> >> Jacopo
> >>
> >>
> >> [EMAIL PROTECTED] wrote:
> >>> Author: jleroux
> >>> Date: Tue Dec 18 12:58:04 2007
> >>> New Revision: 605326
> >>>
> >>> URL: http://svn.apache.org/viewvc?rev=605326&view=rev
> >>> Log:
> >>> A patch from BJ Freeman "Can not activate the Payment Authorization
> >>> Service in accounting ManualTransaction"
> >>> (https://issues.apache.org/jira/browse/OFBIZ-1350) - OFBIZ-1350
> >>>
> >>> Modified:
> >>>
> >>> ofbiz/trunk/applications/accounting/webapp/accounting/payment/manualTx.ftl
> >>>
> >>>
> >>> Modified:
> >>> ofbiz/trunk/applications/accounting/webapp/accounting/payment/manualTx.ftl
> >>>
> >>> URL:
> >>>
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/webapp/accounting/payment/manualTx.ftl?rev=605326&r1=605325&r2=605326&view=diff
> >>>
> >>> ==============================================================================
> >>>
> >>> ---
> >>> ofbiz/trunk/applications/accounting/webapp/accounting/payment/manualTx.ftl
> >>> (original)
> >>> +++
> >>> ofbiz/trunk/applications/accounting/webapp/accounting/payment/manualTx.ftl
> >>> Tue Dec 18 12:58:04 2007
> >>> @@ -67,6 +67,8 @@
> >>>              <input type="hidden" name="transactionType"
> >>> value="${currentTx.enumId}">
> >>>            <#else>
> >>>              <select name="transactionType"
> >>> onchange="javascript:document.manualTxForm.submit();">
> >>> +            <#-- the select one option is so the list will fire on
> >>> any seletion -->
> >>> +              <option value="Select
> >>> one">${uiLabelMap.CommonSelectOne}</option>
> >>>                <#list paymentSettings as setting>
> >>>                  <option
> >>> value="${setting.enumId}">${setting.get("description",locale)}</option>
> >>>                </#list>
> >>>
> >
> >
> >
> >
>

Reply via email to