[
https://issues.apache.org/jira/browse/OFBIZ-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570779#action_12570779
]
David E. Jones commented on OFBIZ-1030:
---------------------------------------
I'm with the patch, especially in terms of what it does.
It does seem like the solution is overly complex, kind of like a logging
utility that could be its own little project (small, like an Apache Commons
thing). In short what concerns me with that sort of thing, while it might be
great, is the maintenance going forward. It may not be a problem per se, but
might the code might be neglected in ways that it wouldn't be if it were part
of another project, like an Apache Commons thing.
Which is the next point... is there something in Apache Commons or somewhere
similar that would do SQL logging like this?
As for OFBiz itself and a simple solution, why not just add some
Debug.logVerbose settings, kind of like the stuff in GenericDAO.java on line
755, but maybe less "gated", or rather make it easier to turn those on by
changing the standard logging settings in the log4j.xml file.
> Ofbiz SQL-Logging Extension
> ---------------------------
>
> Key: OFBIZ-1030
> URL: https://issues.apache.org/jira/browse/OFBIZ-1030
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
> Affects Versions: SVN trunk
> Environment: Win XP
> Reporter: Karl Eilebrecht
> Assignee: Si Chen
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OfbizLoggingDbAccessEn.pdf, patch9672.patch
>
>
> This issue is part of Key-Work Ofbiz Contribution Proposal.
> http://docs.ofbiz.org/display/OFBIZ/Key-Work+Ofbiz+Contribution+Proposal
> Based on Release: 540035
> Includes: -
> Required: JIRA-1029, JIRA-1017, JIRA-1016
> Recommended: -
> Classes: DBAccessLog.java, DBAccessLogEventFactory.java,
> DBAccessLogProcessor.java,
> DefaultSqlLogOutputStrategy.java, SqlLogNamedArgsMap.java,
> SqlLogOutputStrategy.java, SqlLogReplacements.java,
> SqlLogStatementInterceptor.java, SqlLogUtils.java,
> SQLProcessor.java
> Description: This patch adds enhanced logging support for all sql
> statements including arguments ofbiz sends to the DBMS.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
