[
https://issues.apache.org/jira/browse/OFBIZ-1691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12575258#action_12575258
]
Jacques Le Roux commented on OFBIZ-1691:
----------------------------------------
Hi Bruno,
Cool thanks, I will review and commit soon. There is just a quirk in this
replacement line
-<?xml version="1.0" encoding="UTF-8"?>
+<?xml version="1.0" encoding="UTF-8"?>
not sure why. It's not a problem for now (I will remove this chunk) but you
should check why this appearred
> Clear CommonUiLabels redundant redefinition
> -------------------------------------------
>
> Key: OFBIZ-1691
> URL: https://issues.apache.org/jira/browse/OFBIZ-1691
> Project: OFBiz
> Issue Type: Improvement
> Components: ecommerce, framework, manufacturing, order, party
> Affects Versions: SVN trunk
> Environment: WinXP
> Reporter: Bruno Busco
> Priority: Minor
> Attachments: commonlabels.patch
>
>
> CommonXXX labels are defined in CommoUiLabels.xml file with an almost
> complete language support but some of these labels are also duplicated (with
> the same content) also in other resource files like: EcommerceUiLabes,
> OrderUiLabels, PartyUiLabels, ManufacturingUiLabels and SecurityextUiLabels.
> These copies seem also to have been forgotten becouse there are much less
> language defined than in the CommonUiLabels.
> In the attached patch there is a tentative to reduce the possibility to get
> confused while looking for the correct language string to update or for the
> correct place where a new language must be added.
> What I have done is:
> - Removed from EcommerceUiLabels all the definitions already present in
> CommonUiLabels (the "cs" language translation that was missing in
> CommonUiLabels has been added from EcommerceUiLabels)
> - Removed from OrderUiLabels, PartyUiLabels, ManufacturingUiLabels and
> SecurityextUiLabels all the definitions already present in CommonUiLabels
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
