[ 
https://issues.apache.org/jira/browse/OFBIZ-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12595993#action_12595993
 ] 

Marco Risaliti commented on OFBIZ-1780:
---------------------------------------

Hi Jacques,

I'm thinking that the patch in OFBIZ-1698 is a very important task to be done 
but I think it's not valid for Order and Ecommerce applications because it's 
not enough to move label duplicated into OrderUiLabels.xml and 
EcommerceUiLabels.xml to EcommerceUiLabels.xml.
I think that every single label that is used only in Ecommerce has to be put 
into EcommerceUiLabels.xml and instead if it's used on both application it has 
to be renamed to OrderXXX and change all the references to this one.
For example the label EcommerceAddAllToCart has to be renamed to 
OrderAddAllToCart because it was used on both applications.

Thanks
Marco

> Clean up labels between order and ecommerce application
> -------------------------------------------------------
>
>                 Key: OFBIZ-1780
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1780
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ecommerce, order
>    Affects Versions: SVN trunk
>            Reporter: Marco Risaliti
>            Assignee: Marco Risaliti
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: cleanup_labels.patch
>
>
> Clean up labels between order and ecommerce application.
> If a label has been used between order and ecommerce application it will be 
> converted to OrderXXX style and instead if they has been used by a specific 
> application they will be converted to that specific style (OrderXXX or 
> EcommerceXXX).
> This is the first patch and some more work is needed.
> Let me know what did you think of it ?
> Thanks
> Marco

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to