Re: svn commit: r657701 - in /ofbiz/trunk/framework: base/src/base/org/ofbiz/base/util/ common/script/org/ofbiz/common/ common/servicedef/ common/src/org/ofbiz/common/ service/config/ service/src/org/ofbiz/service/engine/

[David E Jones]

Let's just kill the ECA rule that calls it. I'm not sure what it was  
originally intended for anyway, and I just moved it away from the  
service I wanted to test (the bsh test service) so I could test it.

It is supposed to cause an error, so we should probably just comment  
out the ECA and let it be called directly only for now...

-David



On May 24, 2008, at 4:23 AM, Scott Gray wrote:

Hi David,

Currently the blockingTestScv is set to fail due to a transaction  
timeout
(timeout is 20 sec, the service blocks for 30 sec), so using it in  
an eca
for testScv is causing one of the service engine unit tests to  
fail.  I can
either revert that portion of the commit below or change the 20 sec  
timeout,
any preference?

Thanks
Scott

Snipped commit log:
2008/5/19 <[EMAIL PROTECTED]>:

Author: jonesde
Date: Sun May 18 17:22:46 2008
New Revision: 657701

URL: http://svn.apache.org/viewvc?rev=657701&view=rev
Log:
Added support for groovy services, and an example of the same;  
cleaned up
the way that bsh services work and updated the example and such to  
match,
now returns a context as one would expect

Added:
  ofbiz/trunk/framework/common/script/org/ofbiz/common/ 
BshServiceTest.bsh
    - copied, changed from r657609,
ofbiz/trunk/framework/common/src/org/ofbiz/common/BshServiceTest.bsh

ofbiz/trunk/framework/common/script/org/ofbiz/common/ 
GroovyServiceTest.groovy

ofbiz/trunk/framework/service/src/org/ofbiz/service/engine/ 
GroovyEngine.java
 (with props)
Removed:
  ofbiz/trunk/framework/common/src/org/ofbiz/common/ 
BshServiceTest.bsh
Modified:
  ofbiz/trunk/framework/base/src/base/org/ofbiz/base/util/ 
GroovyUtil.java
  ofbiz/trunk/framework/common/servicedef/secas_test.xml
  ofbiz/trunk/framework/common/servicedef/services_test.xml
  ofbiz/trunk/framework/service/config/serviceengine.xml

ofbiz/trunk/framework/service/src/org/ofbiz/service/engine/ 
BeanShellEngine.java


Modified: ofbiz/trunk/framework/common/servicedef/secas_test.xml
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/servicedef/secas_test.xml?rev=657701&r1=657700&r2=657701&view=diff

= 
= 
= 
= 
= 
= 
= 
= 
= 
=====================================================================
--- ofbiz/trunk/framework/common/servicedef/secas_test.xml (original)
+++ ofbiz/trunk/framework/common/servicedef/secas_test.xml Sun May 18
17:22:46 2008
@@ -28,7 +28,7 @@
       <condition field-name="message" operator="equals"  
value="12345"/>
       <action service="testBsh" mode="sync"/>
   </eca>
-    <eca service="testBsh" event="commit">
+    <eca service="testScv" event="commit">
       <condition-service service-name="conditionReturnTrue"/>
       <action service="blockingTestScv" mode="sync"/>
   </eca>