Re: svn commit: r672191 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/datasource/GenericDAO.java

[Jacques Le Roux]

Hi Jacopo,

I just fixed the formatting issues, I did it too fast, sorry.
When you were using a group by with a count in a view-entity you did not get 
all the possible results. It's easy to try by creating
a specific entity-view and looking for its results in webtools/entities data 
maintenance(All).

If you are interested I can send you more informations

Jacques

From: "Jacopo Cappellato" <[EMAIL PROTECTED]>

Hi Jacques,

just curious, what was the bug that you fixed here?

Thanks,

Jacopo

PS: there are some minor formatting issues in the patch


On Jun 27, 2008, at 10:43 AM, [EMAIL PROTECTED] wrote:

Author: jleroux
Date: Fri Jun 27 01:43:00 2008
New Revision: 672191

URL: http://svn.apache.org/viewvc?rev=672191&view=rev
Log:
Fix a Group By bug when using Count (View Entities)

Modified:
   ofbiz/trunk/framework/entity/src/org/ofbiz/entity/datasource/ GenericDAO.java

Modified: ofbiz/trunk/framework/entity/src/org/ofbiz/entity/ 
datasource/GenericDAO.java
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/src/org/ofbiz/entity/datasource/GenericDAO.java?rev=672191&r1=672190&r2=672191&view=diff
= = = = = = = = 
======================================================================
--- ofbiz/trunk/framework/entity/src/org/ofbiz/entity/datasource/ 
GenericDAO.java (original)
+++ ofbiz/trunk/framework/entity/src/org/ofbiz/entity/datasource/ 
GenericDAO.java Fri Jun 27 01:43:00 2008
@@ -970,7 +970,18 @@
            sqlP.executeQuery();
            long count = 0;
            ResultSet resultSet = sqlP.getResultSet();
-            if (resultSet.next()) {
+            boolean isGroupBy = false;
+            if (modelEntity instanceof ModelViewEntity) {
+              ModelViewEntity modelViewEntity = (ModelViewEntity)  modelEntity;
+              String groupByString =  
modelViewEntity.colNameString(modelViewEntity.getGroupBysCopy(), ",  ", "", 
false);
+
+              if (UtilValidate.isNotEmpty(groupByString)) isGroupBy  = true;
+            }
+
+            if (isGroupBy) {
+              while (resultSet.next()) count++;
+            }
+            else if (resultSet.next()) {
                count = resultSet.getLong(1);
            }
            return count;