On Jun 28, 2008, at 12:42 AM, Ashish Vijaywargiya wrote:

I have NO idea what the point of the WorkEffort.statusChangeNote field is,
so please do share your thoughts on what that field will be used



for and why it is on the WorkEffort entity (as opposed to, say, the
WorkEffortStatus entity).


The idea of introducing the field in WorkEffort entity(statusChangeNote) was
to put the reason of WorkEffort Status change.
And if user changes the Status again then we would like to maintain the Old
Status Note provided in statusChangeNote field.
So from the code snippet shown below from the file
WorkEffortSimpleServices.xml, we are putting the old value from
WorkEffort.statusChangeNote field in the WorkEffortStatus.reason field.

I see where you're going with this now.

Why not just have the reason on the WorkEffortStatus entity for each time it is changed? I can't think of a reason why we would need, or want, it on the WorkEffort entity since the field there would describe the last status change, and status changes are what the WorkEffortStatus entity is all about.

+<set from-field="lookedUpValue

.statusChangeNote"
field="newWorkEffortStatus.reason"/>



From the next time I will propose the changes on the Dev mailing list first and wait for some time for any feedback from the community members and then after finalizing the discussion if occurs in b/w the members I will put the
code in the trunk.

For now, should we revert this?

We should at least get rid of the WorkEffort.statusChangeNote. For the WorkEffortStatus.reason field, we might want to discuss it first... for example: do we want a free-form text entry box (which the current field would support), or do we want a drop-down to select among pre- configured reasons, for which we'd want to have a field like "reasonEnumId".

-David

Reply via email to