our current version of derby is the last official release 10.3.1.3
This supports the Alter column, instead of the RENAME COLUMN currently
in DatabaseUtil
this break the modifying of the DB.
So I propose using the DAOHELPEr since it is assigned in the
entityengine.xml
            helper-class="org.ofbiz.entity.datasource.GenericHelperDAO"
Modify the interface Generic Helper to process Reserved words
Add a String ProcessReservedWords(string word){return word;}
to the Helper files that use the interface
Copy and modify the GenericHelperDAO to GenericHelperDAODerby10_3_1_3
fill out
String ProcessReservedWords(string word){return word;}
to return Alter for Rename otherwise return word.
Then wrap all the reserved words in DatabaseUtil or any other java file
that has reserved words, with ProcessReservedWords();
then change the entityengine.xml for derby to
helper-class="org.ofbiz.entity.datasource.GenericHelperDAODerby10_3_1_3"

if this meets with the approval i will create a jira and patch.

BJ Freeman sent the following on 7/17/2008 6:56 AM:
> sigh
> version 10.3.1.4
> is not an official release
> 
> so do we wait for the release
> or fix code to work with ALTER
> version 10.3.1.3
> 
> 
> 
> 
> BJ Freeman sent the following on 7/16/2008 1:33 PM:
>> David it is the derby (ottb db)
>> from the jira I found for DB is seems they fixed it in
>> http://issues.apache.org/jira/browse/DERBY-1490
>> version 10.3.1.4
>> we have 10.3.1.3
>> so upgrading the drivers should solve the problem
>>
>> David E Jones sent the following on 7/16/2008 1:24 PM:
>>> Could you be more specific about the problem? I'm not able to figure
>>> that our based on the solution you are proposing...
>>>
>>> Which database are you using? What SQL in particular is not supported,
>>> and what does that SQL need to look like to work?
>>>
>>> -David
>>>
>>>
>>> On Jul 16, 2008, at 1:38 PM, BJ Freeman wrote:
>>>
>>>> I moved this from user since some thought has to be put in on how to
>>>> handle different DB that use different reserved words.
>>>>
>>>> currently it is hard coded for instance to use rename for a column.
>>>> However our default DB OTTB uses Alter for a column
>>>>
>>>> my suggestion is use framework\entity\dbparms
>>>> folder and put in files that denote each db.
>>>> this way the code would be changed only by adding routine to look of the
>>>> db equivalent for Rename.
>>>>
>>>> any other Ideas.
>>>>
>>>
>>>
>>
>>
>>
> 
> 
> 
> 

Reply via email to