On Jul 18, 2008, at 3:23 AM, Jacopo Cappellato wrote:

On Jul 18, 2008, at 11:13 AM, Bilgin Ibryam wrote:


Jacopo, Adrian, Ashish, thanks for your comments.
Then I'd like to propose the following changes:

Add fromDate - thruDate fields to following entities:
ProductStoreGroupRole
FacilityGroupRole
FacilityRole
AgreementRole
MarketingCampaignRole
SegmentGroupRole

Just keep in mind these are a PITA to change, so unless someone has a reason to change each one of them I wouldn't recommend it, I guess unless you're really bored or something...

Anyway, what I mean by that is the stuff I described to Adrian about changing entities in certain ways, especially when changing the primary key. There is a short description of this on this page:

http://docs.ofbiz.org/display/OFBTECH/General+Entity+Overview

It's in the Deprecated Entities section of that page.

It makes sense to me, even if changing the primary keys of entity is a pain (especially if we do this without having a real world problem to address); if we will do this (I'd like to hear others opinion) we may also commit some maintenance services that can be invoked to upgrade the data in these entities from an older version.

Remove fromDate - thruDate fields to following entities:
PicklistRole

Hmmm... I was not aware that the from/thru fields were already in the PicklistRole entity... if this is the case, then maybe we should leave them in.

I agree. If it's there let's leave it.

-David

Reply via email to