[ 
https://issues.apache.org/jira/browse/OFBIZ-1885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615014#action_12615014
 ] 

Jacopo Cappellato commented on OFBIZ-1885:
------------------------------------------

Hi Adrian,

this is interesting, thanks for sharing your work in progress.
IMO it would be better to rename the entity "VisualThemeType" to "VisualTheme" 
so that the naming conventions for the header/item patter are better followed:

VisualTheme
     |______________> VisualThemeResource
     |______________> VisualThemeResource
     |______________> VisualThemeResource
     ....

Also, but not sure about this: would it make sense to store the 
VisualThemeResourceTypes in the Enumeration entity instead of their own one?




> Selectable Visual Themes
> ------------------------
>
>                 Key: OFBIZ-1885
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1885
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: visual_theme_data.patch
>
>
> Implement entities, services, and UI artifacts to add support for selectable 
> Visual Themes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to