[
https://issues.apache.org/jira/browse/OFBIZ-1924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrian Crum updated OFBIZ-1924:
-------------------------------
Attachment: FlexibleStringExpander_Complete_Refactor.patch
FlexibleStringExpander_Complete_Refactor.patch contains the entire refactor.
1. All "new FlexibleStringExpander(...)" occurrences have been replaced with
the factory method.
2. The refactored FlexibleStringExpander class has been tested - it seems to be
working well.
I decided to cache only the expressions that need expanding. I simplified the
class enough that a FlexibleStringExpander instance that only wraps a String
doesn't create much overhead.
If anyone wants to test this, that would be great. Otherwise I'll wait a few
days, then commit it.
> Sandbox: Improved FlexibleStringExpander class
> ----------------------------------------------
>
> Key: OFBIZ-1924
> URL: https://issues.apache.org/jira/browse/OFBIZ-1924
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: FlexibleStringExpander.patch,
> FlexibleStringExpander.patch, FlexibleStringExpander_Complete_Refactor.patch
>
>
> As discussed on the dev mailing list, implement an improved
> FlexibleStringExpander that uses a factory method to create class instances.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
