[
https://issues.apache.org/jira/browse/OFBIZ-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625673#action_12625673
]
Jacques Le Roux commented on OFBIZ-1928:
----------------------------------------
I did a quick review, there is one point that should have been dealed with :
<fail-message message="ProductStore with id ${productStoreId} has Y for
oneInventoryFacility but inventoryFacilityId is empty, not reserving
inventory."/>
<fail-message message="Facility with id ${parameters.facilityId} is not
associated to ProductStore with id ${parameters.productStoreId}, not reserving
inventory."/
These are not localisable :/
I know it does not come from you as it was already in code. But please, in such
cases use rather <fail-property> instead. I even opened a Jira issue for this
OFBIZ-1874
Thanks for the good work !
PS : It's ok for logs of course
> Allow the Shopping Cart to accept a facility per ship group to specify where
> inventory should be reserved from.
> ---------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1928
> URL: https://issues.apache.org/jira/browse/OFBIZ-1928
> Project: OFBiz
> Issue Type: New Feature
> Components: order
> Affects Versions: SVN trunk
> Environment: Windows XP, Eclipse
> Reporter: Len Shein
> Assignee: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: AddFacilityIdToShipGroup.txt,
> UpdatedAddFacilityIdToShipGroup.txt
>
>
> Modified the Cart Ship group to accept a facility id. On order generation
> the facility id is then stored in entity OrderItemShipGroup. During the
> reserve Inventory process inventory is then reserved from the specified ship
> group facility.
> Patch file to be attached.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
