[
https://issues.apache.org/jira/browse/OFBIZ-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656651#action_12656651
]
Jacques Le Roux commented on OFBIZ-2073:
----------------------------------------
Hi Erik,
Sorry again, there are some annoying things, for instance
As much as possible we should keep special chars, they are ok and easier to
read, examples :
ProductMinMax
ProductShipmentPlanToOrderItems
ManufacturingDuplicatedComponentInBOM
OrderErrorReturnHeaderItemStatusNotChangedIsNotAValidChange
OrderItemStatusNotChangedIsNotAValidChange
Geo.geoName.CIV
Geo.geoName.LAO
Geo.geoName.PRK
<value xml:lang="fr">Nécessité d'action</value>
Uom.description.TOP
<value xml:lang="it">Errore: stato cambiato da [${lookedUpValue.statusId}] a
[${parameters.statusId}] non è permesso</value> (this one is weird,
reversed) :)
<property key="->Complete">
Also we should keep html decorations, like in
ProductNoteRequireEmailParty
ProductRedExplanation
ManufacturingNote3
OrderEmailAccepted
OrderReportFromDate
OrderReportThruDate
CommonEmptyHeader
<value xml:lang="de"><b>Folgender Fehler trat während des Login-Vorgangs auf:
</b>${errorMessage}</value>
<value xml:lang="fr"><b>Impossible de se connecter à cette
application.</b></value>
We should not remove comments as in
<property key="IsA"><!-- Peter 'is a' employee of company B -->
<property key="OrderSalesTax"> <!-- Maybe something is to be done here to
differentiate Sales Tax and VAT, seems OK so far... -->
<value xml:lang="es">Fecha efectiva</value> <!--value
xml:lang="es">Fecha efectivo</value-->
-
- <!-- Entity field descriptions. The Webtools component will use these
properties
- for online documentation. Field description properties have two forms:
- FieldDescription.[fieldname] - will be used for all fields of that
name
- FieldDescription.[entityname].[fieldname] - will be used for the
specified
- entity field
- -->
<!-- Page Titles -->
<!-- Form Field Labels -->
These are minor issues though. Especially compared too all the good work and
should not prevent to commit as we can remove the concerned hunks. So if you
can't remove them using your code (I suppose you used some program or tool) I
propose we do it by hand.
I did not do it by hand yet because it's more error prone (I may miss or
introduce errors). If you have a program or tool it would be better to do it
with it.
Please let me know what you think.
Thanks
PS : I have fixed 2 issues, the one you reported above (two Spanish
translations for key »CommonEmailPassword) and a typo in French (respectively
in revision 726723 and 726725
> Patch for all language files (*Labels.xml) to correct language order, find
> duplicates or invalid entries
> --------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2073
> URL: https://issues.apache.org/jira/browse/OFBIZ-2073
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Erik Wegner
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: labels.diff.bz2
>
>
> All [2] language files were checked using the script from [OFBIZ-2068], some
> problems[1] remained, because I do not speak Espagnol and some other
> languages. For not loosing duplicates, I appended a number after each entry.
> This should make it easier to find these duplicate entries.
> [1]:
> Please check translation for
> CostComponentType.description.ESTIMATED_LABOR_COST: es1 in file
> applications/product/config/ProductEntityLabels.xml
> Please check translation for
> CostComponentType.description.ESTIMATED_LABOR_COST: es2 in file
> applications/product/config/ProductEntityLabels.xml
> Please check translation for FormFieldTitle_requireEmailOrParty: fr1 in file
> applications/product/config/ProductUiLabels.xml
> Please check translation for FormFieldTitle_requireEmailOrParty: fr2 in file
> applications/product/config/ProductUiLabels.xml
> Please check translation for ProductReserveInventory: fr1 in file
> applications/product/config/ProductUiLabels.xml
> Please check translation for ProductReserveInventory: fr2 in file
> applications/product/config/ProductUiLabels.xml
> Please check translation for OrderCaptureService: es1 in file
> applications/order/config/OrderUiLabels.xml
> Please check translation for OrderCaptureService: es2 in file
> applications/order/config/OrderUiLabels.xml
> Please check translation for OrderCartons: es1 in file
> applications/order/config/OrderUiLabels.xml
> Please check translation for OrderCartons: es2 in file
> applications/order/config/OrderUiLabels.xml
> Please check translation for OrderCubicMeasurement: es1 in file
> applications/order/config/OrderUiLabels.xml
> Please check translation for OrderCubicMeasurement: es2 in file
> applications/order/config/OrderUiLabels.xml
> Please check translation for OrderExcludeCategories: en1 in file
> applications/order/config/OrderUiLabels.xml
> Please check translation for OrderExcludeCategories: en2 in file
> applications/order/config/OrderUiLabels.xml
> Please check translation for OrderFromMondayToTuesday: es1 in file
> applications/order/config/OrderUiLabels.xml
> Please check translation for OrderFromMondayToTuesday: es2 in file
> applications/order/config/OrderUiLabels.xml
> Please check translation for OrderNoPurchaseOrderSpecified: es1 in file
> applications/order/config/OrderUiLabels.xml
> Please check translation for OrderNoPurchaseOrderSpecified: es2 in file
> applications/order/config/OrderUiLabels.xml
> Please check translation for OrderOrderQuoteAdjustmentTypeId: es1 in file
> applications/order/config/OrderUiLabels.xml
> Please check translation for OrderOrderQuoteAdjustmentTypeId: es2 in file
> applications/order/config/OrderUiLabels.xml
> Please check translation for OrderOrderQuoteWorkEffortId: es1 in file
> applications/order/config/OrderUiLabels.xml
> Please check translation for OrderOrderQuoteWorkEffortId: fr1 in file
> applications/order/config/OrderUiLabels.xml
> Please check translation for OrderOrderQuoteWorkEffortId: es2 in file
> applications/order/config/OrderUiLabels.xml
> Please check translation for OrderOrderQuoteWorkEffortId: fr2 in file
> applications/order/config/OrderUiLabels.xml
> Please check translation for OrderProcessingInHoldNote: es1 in file
> applications/order/config/OrderUiLabels.xml
> Please check translation for OrderProcessingInHoldNote: es2 in file
> applications/order/config/OrderUiLabels.xml
> Please check translation for OrderWebSite: es1 in file
> applications/order/config/OrderUiLabels.xml
> Please check translation for OrderWebSite: es2 in file
> applications/order/config/OrderUiLabels.xml
> Please check translation for item.product_not_found: es1 in file
> applications/order/config/OrderUiLabels.xml
> Please check translation for item.product_not_found: es2 in file
> applications/order/config/OrderUiLabels.xml
> Please check translation for OrderErrorCannotHaveUomWithoutDefaultUom: es1 in
> file applications/order/config/OrderErrorUiLabels.xml
> Please check translation for OrderErrorCannotHaveUomWithoutDefaultUom: es2 in
> file applications/order/config/OrderErrorUiLabels.xml
> Please check translation for ManufacturingInventoryEventPlanned: fr1 in file
> applications/manufacturing/config/ManufacturingUiLabels.xml
> Please check translation for ManufacturingInventoryEventPlanned: fr2 in file
> applications/manufacturing/config/ManufacturingUiLabels.xml
> Please check translation for ManufacturingMainPageNote: fr1 in file
> applications/manufacturing/config/ManufacturingUiLabels.xml
> Please check translation for ManufacturingMainPageNote: fr2 in file
> applications/manufacturing/config/ManufacturingUiLabels.xml
> Please check translation for ManufacturingMrpInitialisation: fr1 in file
> applications/manufacturing/config/ManufacturingUiLabels.xml
> Please check translation for ManufacturingMrpInitialisation: fr2 in file
> applications/manufacturing/config/ManufacturingUiLabels.xml
> Please check translation for ManufacturingProduceQuantity: es1 in file
> applications/manufacturing/config/ManufacturingUiLabels.xml
> Please check translation for ManufacturingProduceQuantity: es2 in file
> applications/manufacturing/config/ManufacturingUiLabels.xml
> Please check translation for ManufacturingRequirementId: fr1 in file
> applications/manufacturing/config/ManufacturingUiLabels.xml
> Please check translation for ManufacturingRequirementId: fr2 in file
> applications/manufacturing/config/ManufacturingUiLabels.xml
> Please check translation for ManufacturingTimePeriod: fr1 in file
> applications/manufacturing/config/ManufacturingUiLabels.xml
> Please check translation for ManufacturingTimePeriod: fr2 in file
> applications/manufacturing/config/ManufacturingUiLabels.xml
> Please check translation for PageTitleFindInventoryEventPlan: es1 in file
> applications/manufacturing/config/ManufacturingUiLabels.xml
> Please check translation for PageTitleFindInventoryEventPlan: fr1 in file
> applications/manufacturing/config/ManufacturingUiLabels.xml
> Please check translation for PageTitleFindInventoryEventPlan: es2 in file
> applications/manufacturing/config/ManufacturingUiLabels.xml
> Please check translation for PageTitleFindInventoryEventPlan: fr2 in file
> applications/manufacturing/config/ManufacturingUiLabels.xml
> Please check translation for CommonEmailPassword: es1 in file
> framework/common/config/CommonUiLabels.xml
> Please check translation for CommonEmailPassword: es2 in file
> framework/common/config/CommonUiLabels.xml
> [2]:
> "specialpurpose/pos/config/PosUiLabels.xml",
> "specialpurpose/webpos/config/WebPosUiLabels.xml",
> "specialpurpose/ebay/config/EbayUiLabels.xml",
> "specialpurpose/googlebase/config/GoogleBaseUiLabels.xml",
> "specialpurpose/mypage/config/MyPageUiLabels.xml",
> "specialpurpose/assetmaint/config/AssetMaintUiLabels.xml",
> "specialpurpose/oagis/config/OagisUiLabels.xml",
> "specialpurpose/projectmgr/config/ProjectMgrUiLabels.xml",
> "specialpurpose/shark/config/SharkUiLabels.xml",
> "applications/party/config/PartyUiLabels.xml",
> "applications/party/config/PartyEntityLabels.xml",
> "applications/product/config/ProductEntityLabels.xml",
> "applications/product/config/ProductErrorUiLabels.xml",
> "applications/product/config/ProductUiLabels.xml",
> "applications/order/config/OrderUiLabels.xml",
> "applications/order/config/OrderEntityLabels.xml",
> "applications/order/config/OrderErrorUiLabels.xml",
> "applications/accounting/config/AccountingUiLabels.xml",
> "applications/accounting/config/AccountingEntityLabels.xml",
> "applications/workeffort/config/WorkEffortEntityLabels.xml",
> "applications/workeffort/config/WorkEffortUiLabels.xml",
> "applications/content/config/ContentErrorUiLabels.xml",
> "applications/content/config/ContentUiLabels.xml",
> "applications/content/config/ContentEntityLabels.xml",
> "applications/ecommerce/config/EcommerceUiLabels.xml",
> "applications/humanres/config/HumanResUiLabels.xml",
> "applications/manufacturing/config/ManufacturingReportsUiLabels.xml",
> "applications/manufacturing/config/ManufacturingUiLabels.xml",
> "applications/manufacturing/config/ManufacturingEntityLabels.xml",
> "applications/marketing/config/MarketingEntityLabels.xml",
> "applications/marketing/config/MarketingUiLabels.xml",
> "framework/guiapp/config/XuiUiLabels.xml",
> "framework/common/config/CommonUiLabels.xml",
> "framework/common/config/SecurityextUiLabels.xml",
> "framework/common/config/PrefErrorUiLabels.xml",
> "framework/common/config/CommonEntityLabels.xml",
> "framework/common/config/TemporalExpressionUiLabels.xml",
> "framework/common/config/CommonHelpUiLabels.xml",
> "framework/service/config/ServiceErrorUiLabels.xml",
> "framework/webapp/config/WebappEntityLabels.xml",
> "framework/webapp/config/WebappUiLabels.xml",
> "framework/minilang/config/MiniLangErrorUiLabels.xml",
> "framework/webtools/config/WebtoolsUiLabels.xml",
> "framework/webtools/config/WebtoolsErrorUiLabels.xml",
> "framework/bi/config/BiUiLabels.xml",
> "framework/security/config/SecurityEntityLabels.xml",
> "framework/example/config/ExampleEntityLabels.xml",
> "framework/example/config/ExampleHelpUiLabels.xml",
> "framework/example/config/ExampleUiLabels.xml",
> "framework/base/config/DateTimeLabels.xml"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
