[
https://issues.apache.org/jira/browse/OFBIZ-1914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661448#action_12661448
]
David E. Jones commented on OFBIZ-1914:
---------------------------------------
It sounds like we need to separate the parsing from the post-parse processing.
The entity and services engines do this, but in a way that I don't think will
work here... they read in the entire model and process extensions and
inheritances after everything is read in.
While we can't do one big pass for all form files (they are only read when used
unlike the entity and service defs), we can split it into a cached parse and a
post-process that is not part of the parse. The post-processing would be done
one form within the file at a time to avoid the circular looping, and with a
method on the form class itself that would keep track of whether or not the
post-processing had already been done. When the form extension code runs it
would get the form from the cache (as now), and then make sure the
post-processing is done just for that form.
Is anyone already looking at this? If not I'll take a gander in the near
future...
> form 'extend' can bring system in a loop
> ----------------------------------------
>
> Key: OFBIZ-1914
> URL: https://issues.apache.org/jira/browse/OFBIZ-1914
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Environment: any
> Reporter: Hans Bakker
> Fix For: SVN trunk
>
>
> If a form xml extends a form from a second form xml file and that second form
> xml extends a different form in the first xml file, the system comes in a
> loop. This prohibits the re-usage of forms significantly. An example of the
> log file when i want to use a communication list on a request and a request
> list on a communication:
> 2008-08-10 07:09:52,661 (http-0.0.0.0-8443-1) [
> UtilXml.java:241:INFO ] XML Read 0.014s:
> file:/home/hans/ofbiz/svn/applications/order/webapp/ordermgr/request/RequestForms.xml
> 2008-08-10 07:09:52,683 (http-0.0.0.0-8443-1) [
> UtilXml.java:241:INFO ] XML Read 0.016s:
> file:/home/hans/ofbiz/svn/applications/party/webapp/partymgr/communication/CommForms.xml
> 2008-08-10 07:09:52,765 (http-0.0.0.0-8443-1) [
> UtilXml.java:241:INFO ] XML Read 0.065s:
> file:/home/hans/ofbiz/svn/applications/order/webapp/ordermgr/request/RequestForms.xml
> 2008-08-10 07:09:52,818 (http-0.0.0.0-8443-1) [
> UtilXml.java:241:INFO ] XML Read 0.047s:
> file:/home/hans/ofbiz/svn/applications/party/webapp/partymgr/communication/CommForms.xml
> my knowledge of the widget frmaework system is restricted...if anybody can
> help?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
