[ 
https://issues.apache.org/jira/browse/OFBIZ-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stephen Rufle updated OFBIZ-2115:
---------------------------------

    Attachment: 2009-01-14_001_shoppingcart.patch

After this issue was initially created I modified the appendOrderItem service 
by adding 2 new parms to the service definition and modified 
OrderServices.addItemToApprovedOrder to use them

Patch 
- Adds an overloaded makeAllOrderAttributes to ShoppingCart that takes parms 
for returning Filled and Empty attributes ( the defined constants are also used 
for OrderItemAtrributes)
- Fixes a misnamed variable issue in ShoppingCartServices , the section with 
the comment  "load order item contact mechs" had a var named 
orderAttributesList i thought it should have been teh orderItemContactMechList 
just above instead
- There are also some tab to spaces fixes

> OrderServices.updateApprovedOrderItems should update OrderItemAttributes
> ------------------------------------------------------------------------
>
>                 Key: OFBIZ-2115
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2115
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: Windows XP
>            Reporter: Stephen Rufle
>             Fix For: SVN trunk
>
>         Attachments: 2009-01-08_001_OrderItemAtrributes.patch, 
> 2009-01-14_001_shoppingcart.patch
>
>
> I wanted updateApprovedOrderItems to be able to update any 
> OrderItemAttributes there may be. added a new map (itemAttributesMap) to 
> /applications/order/servicedef/services.xml#updateOrderItems the key value of 
> the map should be in the form of
> attibuteName+ ":" + orderItemSeqId
> At the top of
> OrderServices.updateApprovedOrderItems(DispatchContext, Map) I create a new 
> map with only the attribute names, later in the same method we repopulate the 
> cartItem's OrderItemAttributes with any non-empty values. In 
> saveUpdatedCartToOrder we call my modified 
> ShoppingCart.makeAllOrderItemAttributes(String, int) I added the ability to 
> return just empty , just filled or both empty and filled. 
> For previously filled attributes that are now empty I remove them from the 
> database. for either new or chnaged ones they are just added to the toStore 
> that already existed 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to