Yes, actually to be frank I did it in a hurry and forgot about using rel-field-name and also I guess I copied from PeriodType (just
above in file) which has the same issue.
Done in r736586
Should we change PeriodType also (inconvenient for legacy reasons I guess) ?
Actually
FixedAsset,
InvoiceItem, InvoiceTerm (no relation with Uom),
SettlementTerm (no relation with Uom),
BillingAccountTerm,
OrderTerm,
QuoteItem, QuoteTerm (no relation with Uom),
ProductFeature (no relation with Uom),
InventoryItem
are in the same case...
Jacques
From: "David E Jones" <[email protected]>
This looks good Jacques. One thing I'd recommend changing is the field name "uomId". As-is it is ambiguous. You mentioned the
field it describes in the comment for it, and that's great, but I've been trying to push for more descriptive names that include
the name of the field it modifies, like "elevationUomId" since it only describes the elevation field.
-David
On Jan 18, 2009, at 2:09 AM, [email protected] wrote:
Modified: ofbiz/trunk/framework/common/entitydef/entitymodel.xml
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/entitydef/entitymodel.xml?rev=735404&r1=735403&r2=735404&view=diff
= = = = = = = =
======================================================================
--- ofbiz/trunk/framework/common/entitydef/entitymodel.xml (original)
+++ ofbiz/trunk/framework/common/entitydef/entitymodel.xml Sun Jan 18 01:09:32
2009
@@ -156,6 +156,7 @@
<field name="geoCode" type="short-varchar"></field>
<field name="geoSecCode" type="short-varchar"></field>
<field name="abbreviation" type="short-varchar"></field>
+ <field name="wellKnownText" type="very-long"></field>
<prim-key field="geoId"/>
<relation type="one" fk-name="GEO_TO_TYPE" rel-entity- name="GeoType">
<key-map field-name="geoTypeId"/>
@@ -205,7 +206,24 @@
<key-map field-name="parentTypeId" rel-field- name="geoTypeId"/>
</relation>
</entity>
-
+ <entity entity-name="GeoPoint" package- name="org.ofbiz.common.geo"
default-resource-name="CommonEntityLabels"
+ title="Geographic Location">
+ <field name="geoPointId" type="id-ne"></field>
+ <field name="dataSourceId" type="id"></field>
+ <field name="latitude" type="floating-point" not-null="true"></ field>
+ <field name="longitude" type="floating-point" not-null="true"></ field>
+ <field name="elevation" type="floating-point"></field>
+ <field name="uomId" type="id"><description>We need an UOM for elevation (feet,
meters, etc.)</description></field>
+ <field name="information" type="comment"><description>To enter any related
information</description></field>
+ <prim-key field="geoPointId"/>
+ <relation type="one" fk-name="GEOPOINT_DTSRC" rel-entity-
name="DataSource">
+ <key-map field-name="dataSourceId"/>
+ </relation>
+ <relation type="one" fk-name="GPT_TYPE_UOM" rel-entity- name="Uom">
+ <key-map field-name="uomId"/>
+ </relation>
+ </entity>
+
<!-- ========================================================= -->
<!-- org.ofbiz.common.keyword -->
<!-- ========================================================= -->
