[
https://issues.apache.org/jira/browse/OFBIZ-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666951#action_12666951
]
Todor Spasov commented on OFBIZ-1825:
-------------------------------------
Hello Marco,
Regarding this code from your patch:
{code:title=calendar_date_select.js|borderStyle=solid}
initialize: function(calendar_panel, options) {
this.options = $H(options || {});
this.calendar_panel = $(calendar_panel);
dhtmlLoadScript('/images/calendar/date.js');
var synchronousOptions = {symbol: 'coolFeature', timeout:0.001,
onSuccess: this.start.bind(this), onTimeout: this.start.bind(this)};
if (this.options.get("locale"))
dhtmlLoadScript('/images/calendar/i18n/LocalizedDate_'+
this.options.get("locale") + '.js', synchronousOptions);
},
{code}
Would you please give an example for LocalizedDate_it.js file as I cannot quite
figure its content?
I am willing to convert the modified patch according to Jacques Le Roux's
remarks.
Thanks,
Todor
> Colors and localisation for the calendar
> ----------------------------------------
>
> Key: OFBIZ-1825
> URL: https://issues.apache.org/jira/browse/OFBIZ-1825
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: Release Branch 9.3
>
> Attachments: calendar.patch, calendar_sequence.patch,
> calendarDateSelectColor.patch, calendarDateSelectColor.patch,
> calendarModified.patch, Existing.jpg, Proposition.jpg, WE_CAL.gif
>
>
> I tried to change the calendar colors, to be more "in the OFBiz way". Please
> let me you know what you think.
> I also changed some colors to respect our CSS best practices (no color names).
> Here are some remarks :
> Colors
> * I kept the 3 chars scheme when it's was obvious. For instance we don't
> need to set #000000 or #ffffff when actually #000 or #fff is sufficient.
> * I used Wikipedia as reference http://en.wikipedia.org/wiki/Web_colors for
> choising colors. While doing this change I wondered if we could not authorise
> and even recommend to use sandard names for colors as shown in Wikipedia
> page. I found it easier to recall a color by its names than by an hexa
> number...! As long as we would use this Wikipedia reference I think it could
> be possible to use names instead of hexa, WDYT ?
> * The days initials are not centered but at left (It's late and I did not
> found the reason)
> We need to provide a localisation mean. From
> http://electronicholas.com/calendar?style=default&format=natural it should
> not be too hard. I propose a simple way, maybe we can do better
> * More calendar formats in a calendar.properties file (like the euro or
> american ones)
> * For the moment I think all string are harcoded in calendar_date_select.js
> Date.weekdays = $w("S M T W T F S");
> Date.first_day_of_week = 0;
> Date.months = $w("January February March April May June July August
> September October November December" );
> _translations = {
> "OK": "OK",
> "Now": "Now",
> "Today": "Today"
> }
> A very simple way (but not very clever I must admit) could be to set a
> property for the language to use in calendar.properties file and use it in a
> switch statement with "hardcoded" strings in calendar_date_select.js. Is
> anybody aware of better ways to do that in Javascript or Prototype ?
> BTW I think we should delete calendarstyles.css and calendarTable.css. If
> it's ok, I will do it when I will upate the attached patch later.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
