[ 
https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670555#action_12670555
 ] 

Jacques Le Roux commented on OFBIZ-1700:
----------------------------------------

I think, it's always better to keep comments in issue and not diverging on dev 
ML

{quote}Yes this seems wiser/simpler indeed.
The "unknown" generation should not be only in "ant build"' I guess, at least 
"ant run-install" as well and surely more (I use 
mostly these 2)

Jacques

From: "Bruno Busco" <[email protected]>
> Yes,
> this is a good point.
> I agree but I then suggest to have the svninfo.ftl not committed.
> It will be created by a "ant build" command (with "unknown") and/or by the
> "ant svinfo" (with the correct version).
>
> If this is ok I will proceed to update the patch.
> -Bruno
{quote}

Finally I thought about that a bit more and I think it's easier to do it as I 
did : you don't have to worry about existing and future targets. In any case, 
if svninfo was not run, "unknown" will be shown. We may even put an information 
about that in svinfo.ftl : instead of only
unknwon
put
unknwon (run "ant svninfo" to show your version)

> To show Current Revision number of OFBiz on its home site that will facilate 
> in testing and comparing things with a local copy of OFBiz 
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1700
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1700
>             Project: OFBiz
>          Issue Type: New Feature
>            Reporter: Vikas Mayur
>            Assignee: Jacques Le Roux
>         Attachments: about_app.zip, about_ss.JPG, screenshot1.png, 
> screenshot2.png, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, 
> svninfo_ss1.gif, svninfo_ss2.gif
>
>
>  We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz 
> home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques 
> at http://www.nabble.com/Mention-of-version---in-release-to13078575.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to