Hello David, I am reviewing this now and will do the needful soon.
-- Ashish On Mon, Feb 9, 2009 at 4:30 PM, Jacopo Cappellato <[email protected]> wrote: > I think this is related to something I suggested: modifying the primary key > of the shipping estimates entity to enhance flexibility. > Probably the code that is broken now should be updated to reflect that > change. > > Just my 2 cents... I will try to look at this as soon as I have some free > time, if Ashish and co. will not reply before. > > Cheers, > > Jacopo > > On Feb 9, 2009, at 11:35 AM, David E Jones wrote: > >> >> We've had another complaint about this on the mailing list now... >> >> Here is the commit that Jacques is referring to: >> >> >> http://www.nabble.com/svn-commit:-r727381---in--ofbiz-trunk-applications:-ecommerce-script-org-ofbiz-ecommerce-customer--ecommerce-webapp-ecommerce-images--order-src-org-ofbiz-order-shoppingcart--order-src-org-ofbiz-order-shoppingcart-shipping--product-entitydef--product-se...-td21053476.html >> >> It looks like it was committed by Ashish, and there are credits for two of >> his coworkers: Arun Patidar & Jyotsna Rathore. Could one of you please look >> into this and comment on what this was meant for and if we can remove it and >> use something else, or should we build it out so it does not cause this >> error? >> >> Thanks, >> -David >> >> >> On Jan 18, 2009, at 12:25 PM, Jacques Le Roux wrote: >> >>> I checked using FishEye and Nabble, it seems that >>> OrderItemShipGroup.productStoreShipMethId field never existed. Note that >>> there are >>> such fields in some Product entities >>> >>> String productStoreShipMethId = cart.getProductStoreShipMethId(); >>> was introduced in in r727381 (OFBIZ-2082) >>> >>> I guess we should better use >>> cart.getProductStoreShipMethId(); >>> But this means to pass a cart somehow. I did not look further >>> >>> This prevent to add some types of Product to an existing order and should >>> be fixed ASAP >>> >>> Thanks >>> >>> Jacques >>> >>> From: "David E Jones" <[email protected]> >>>> >>>> It appears that there used to be a >>>> OrderItemShipGroup.productStoreShipMethId field, but there is no longer >>>> one, and when an >>>> order is saved the productStoreShipMethId in the ShoppingCart object is >>>> no longer saved. >>>> >>>> If anyone knows anything about this... Is that correct? If so, why was >>>> this change made? >>>> >>>> If no one knows anything about this then I think some investigation is >>>> needed... :( >>>> >>>> There is still some code that tries to use it that flares up when >>>> trying to edit an order item (orderdetail page in the Order >>>> Manager, Edit Items link, change quantity on any item): >>>> >>>> 2009-01-10 15:35:14,759 (http-0.0.0.0-8443-2) [ >>>> ServiceDispatcher.java:500:ERROR] >>>> ---- exception report >>>> ---------------------------------------------------------- >>>> Service [recalcShippingTotal] threw an unexpected exception/error >>>> Exception: org.ofbiz.service.GenericServiceException >>>> Message: Service [recalcShippingTotal] target threw an unexpected >>>> exception ([GenericEntity.get] "productStoreShipMethId" is not >>>> a field of OrderItemShipGroup) >>>> ---- cause >>>> --------------------------------------------------------------------- >>>> Exception: java.lang.IllegalArgumentException >>>> Message: [GenericEntity.get] "productStoreShipMethId" is not a field of >>>> OrderItemShipGroup >>>> ---- stack trace >>>> --------------------------------------------------------------- >>>> java.lang.IllegalArgumentException: [GenericEntity.get] >>>> "productStoreShipMethId" is not a field of OrderItemShipGroup >>>> org.ofbiz.entity.GenericEntity.get(GenericEntity.java:308) >>>> org.ofbiz.entity.GenericEntity.getString(GenericEntity.java:585) >>>> >>>> org .ofbiz .order .shoppingcart >>>> .shipping.ShippingEvents.getShipEstimate(ShippingEvents.java:121) >>>> >>>> org .ofbiz >>>> .order.order.OrderServices.recalcOrderShipping(OrderServices.java:1602) >>>> >>>> -David >>>> >>> >> > >
