Of course, at 1st sight it seems that not having a Windows machine at hand does not facilitate the case. But actually you don't need
to have one
Simply try to enter a Windows style path in Import Xml in Webtools and you will see the problem if you revert my 2 commits (sorry
for that)
If you want to see the error message do it on demo server. But this message
will not help you a lot IMO.
From: "David E Jones" <[email protected]>
Okay, yes, I should have acknowledged that email as well, but it also has no detail... the only relevant bit I can find is this:
"It does not work because in UtilHttp.canonicalizeParameter <<StringUtil.defaultWebEncoder.canonicalize(paramValue,
StringUtil.esapiCanonicalizeStrict);>> does not encode correctly such paths."
In other words, the information I have from both emails is that "it doesn't work". But, WHY doesn't it work? HOW is it failing?
Any error messages or other information about what is actually happening
(perhaps even the stuff I mentioned in my previous email about what the canonicalized String that is causing the problem looks
like)?
The canonicalized String (without my change) is ugly and I guess you will not
get much information from it.
Does that make sense? In other words, I'm saying there is relevant details that are missing and either I have to get OFBiz going
on a Windows machine and test it myself, or try to get more details from you.
:D, don't be upset, I ready to help as much as I can
On the testing it myself note, there aren't even enough details to do that in
here! Which page did you go to?
OFBiz/Webtools/Import Xml
What did you enter?
c:\quelque_chose\nimportequoi (in the filename field)
What happened (so that I can see if I'm experiencing the same thing)?
Try to reproduce on demo server, it should help (Mmm... if it has not been
updated ... OK for now...)
This is really basic stuff... isn't it? I mean, if someone was reporting a bug
to you, what information would YOU want to see?
I tred to give you what it's needed. Let me know if you need more :o)
Jacques
-David
On Feb 15, 2009, at 10:10 AM, Jacques Le Roux wrote:
David,
I just gave some details in a response to Hans's proposition
Thread "Re: svn commit: r744652 -/ofbiz/trunk/framework/base/src/org/
ofbiz/base/util/UtilHttp.java"
Tell me if you need more details
Jacques
From: "David E Jones" <[email protected]>
Jacques,
I also don't like the solution in 744652, it is guaranteed to break other
things.
Could you describe the problem in a little more detail, ie what you do and what happens? The only description I can find in
the emails is "XML Import on Windows does not support anymore \ as separator you must /" and I can only guess about what
that means...
One helpful detail (in addition to a more detailed general description) is what is the input string and what is it after it
is canonicalized?
-David
On Feb 15, 2009, at 3:54 AM, Jacques Le Roux wrote:
Fixed in r744652 (this were it proves useful to have a Windows commiter : not
all our users are on Linux ;o)
Jacques
From: "Jacques Le Roux" <[email protected]>
Actually it's not a regression, it was not working already in R4 (but I
thought it was, weird, maybe it was before...)
Jacques
From: "Jacques Le Roux" <[email protected]>
XML Import on Windows does not support anymore \ as separator you must /
This is a regression
Jacques
