[
https://issues.apache.org/jira/browse/OFBIZ-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673902#action_12673902
]
Jacques Le Roux commented on OFBIZ-2163:
----------------------------------------
Karim,
Some comments :
. Please in FTL use 2 spces indentation even if before some persons have not
respected this rule (it's far easier when checking for end of blocks)
. It works well but I don't understand how the 1st "Next package" button is
working (does not seem related to your work though)
. I did not understand why you used Hashtable in PackingSession.java (but also
FastMap which we prefer)
I have upload an updated paches with some trivial fixes. I will commit as soon
as you will explain me why you removed shippedQuantity from inputQty calculation
Thanks
> Packing issues: weights and remaining items
> -------------------------------------------
>
> Key: OFBIZ-2163
> URL: https://issues.apache.org/jira/browse/OFBIZ-2163
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Environment: any
> Reporter: Karim Rahimpur
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: Packing.patch
>
>
> - package line weights are not cleared when lines are cleared, in:
> PackingSession.clearLine(...)
> PackingSession.clearAllLines(...)
> PackingSession.clear()
> - remaining number of items is not calculated correctly in PackOrder.ftl:
> inputQty
> Example: If the quantity of an order item is shipped in two ship groups and
> the first is packed, the second cannot be packed correctly because the
> remaining quantity is wrong.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
